search

aja-video / libajantv2

Open-source library for AJA Video Systems desktop IO cards.
MIT License
20 stars 13 forks source link

Fixes for two crashes #3

Closed janbrothanek closed 7 months ago

janbrothanek commented 8 months ago

Fixes for two crashes which we found at Comprimato while integrating NTV2.

mrbillaja commented 8 months ago

@janbrothanek do you have a small test case that elicits the SIGSEGV crash in AJAAncillaryList::AddFromDeviceAncBuffer?

I’d like to first confirm the crash in our ut_ajaanc unit test, in test case 'BFT_AddFromDeviceAncBuffer'.

(FYI, we recently discovered we weren’t building ut_ajaanc … we just added it to the build in our main branch.)

janbrothanek commented 8 months ago

@mrbillaja I see I reported the related bugs as #4725 and #4609 in sdksupport.aja.com, and we were asked to reproduce them with newer versions where there were potential fixes. I'm sorry I forgot about that. We always apply the two patches on top of the SDK, just now when the SDK goes to Github, we thought it would be nicer to make a pull request. I'll try to reproduce it sometime soon.