search

ajacksified / hubot-plusplus

Welcome to Hubot, where the points don't matter
MIT License
59 stars 101 forks source link

Get hubot off the dried grapes #65

Closed swalberg closed 8 years ago

swalberg commented 8 years ago

Perhaps Hubot meant to dispense some raisins, or maybe his French raisons is a bit off, but I'll offer to correct this spelling error.

therealklanni commented 8 years ago

Thanks for contributing! This has come up once before and I believe we declined to make the change because it's not a typo, and is intentional. "raisins" is a play on words. You're "raising" a person's score for this "reason"... Hence "raisins"... Raising reasons.

That being said, I didn't write (that part of) this script and I have no attachment to it. Seems enough people want it changed, so I'll go ahead and merge your PR.

One small request before I merge: can you rewrite your commit message to something more conventional that more clearly describes the change? e.g. "change raisins to reasons" in the imperative as in the example, please.

Much appreciated, thanks! :metal:

swalberg commented 8 years ago

Thanks for reviewing the PR and explaining the history. I've updated the commit message.

ajacksified commented 8 years ago

It would be preferable to make it a configuration option rather than changing it outright.

swalberg commented 8 years ago

Hi, thanks for the suggestion. I guess I could override that word. It's just that options increase complexity (albeit not a whole lot here) and the reference seems really stretched (given I'm the third person to submit a PR to change it).

If it were to be an option, would you see it as a free form one or a toggle between reasons and raisins?

ajacksified commented 8 years ago

Definitely freeform, with a default of raisins. On Apr 25, 2016 1:25 PM, "Sean Walberg" notifications@github.com wrote:

Hi, thanks for the suggestion. I guess I could override that word. It's just that options increase complexity (albeit not a whole lot here) and the reference seems really stretched (given I'm the third person to submit a PR to change it).

If it were to be an option, would you see it as a free form one or a toggle between reasons and raisins?

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/ajacksified/hubot-plusplus/pull/65#issuecomment-214509071

swalberg commented 8 years ago

Hi Jack, I've added it as a second commit.

therealklanni commented 8 years ago

👍 from me

ajacksified commented 8 years ago

👍

ajacksified commented 8 years ago

published@v1.2.5

swalberg commented 8 years ago

Thanks!