search

ajacocks / fah

Folding-at-home installer for Linux
GNU General Public License v3.0
7 stars 8 forks source link

moved config template to role level, added versions to dependencies, … #27

Closed westerj closed 4 years ago

westerj commented 4 years ago

…added docs added become: true to tasks in playbook main.yml changed include to include_task for gpu.yml commented out static - didn't seem to apply and it generated error messages. debug line to show/confirm the version number working. restarted FAHClient to rewrite the config.xml file. (template was messy) moved config.xml to the role level.

I removed the RPM on 3 servers, and ran it

all came back to life. FAHControl node didn't mind. SystemInfo even updated.

All CPU's in one slot for the moment. NVidia conversion is next. Tomorrow. Tested On RHEL7.latest and RHEL8.latest.

dmc5179 commented 4 years ago

@westerj 2 things:

Please remove what appears to be a debug statement from the playbook here: roles/fahclient/tasks/dependencies.yaml

roles/fahclient/tasks/dependencies.yaml contains a task to restart the FAHClient service right before

which are the tasks that actually install the service if this is a local install. We can't call a service restart before the service is installed. This probably worked on a system you tested because the service was already installed but this would fail on a fresh system.

westerj commented 4 years ago

Excellent. Thanks.

The service restart cleans up the config.xml... interesting.

Saw the note sbout not using client type: beta. Had been, but removed. Think i had mentioned it, but should redact.

Thanks for review.

On Sat, Apr 18, 2020, 6:38 AM Dan Clark notifications@github.com wrote:

@westerj https://github.com/westerj 2 things:

Please remove what appears to be a debug statement from the playbook here: roles/fahclient/tasks/dependencies.yaml

  • name: JW echo version/url

roles/fahclient/tasks/dependencies.yaml contains a task to restart the FAHClient service right before

  • import_tasks: service.yaml  when: local_service | bool

which are the tasks that actually install the service if this is a local install. We can't call a service restart before the service is installed. This probably worked on a system you tested because the service was already installed but this would fail on a fresh system.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ajacocks/fah/pull/27#issuecomment-615839193, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACI52JDIKIQR2RSMMC5U26DRNF7LRANCNFSM4MJITPOA .

jwesterd-redhat commented 4 years ago

Updated as requested. TY

jwesterd-redhat commented 4 years ago

updated the file version format.. not sure if the latest.rpm will work... as it does not confer the RPM name as (for example) fahclient...

jwesterd-redhat commented 4 years ago

added V 7.6.9 and 7.6.10. Not sure it the latest (public/beta) will work.