psdcode
commented
2 years ago 1.5 to 2hrs
'Update' is currently a dead button (most of it's code is commented out)
Also, it seems when reload the page with filters parameters present that are different than the defaults, none of the filter parameters are used in the search, and are instead removed from the address bar. This is a similar issue to https://github.com/ajah/sks-interface/issues/30 (see comment there), in that the address bar query params are not properly synced with the app search context parameters used in the app logic.
@gustavohandrade I can either resolve this by
-
a) Remove the Update button, and make an api call and have search results be automatically updated when any filter value is changed
-
b) Only update address bar with changed filters when click Update button after changing filters
let me know what you prefer.
Also, I recommend (although this should be a separate issue):
- changing city search button to a '+', and having the city name show up in a tile right below when click + button. Then, as long as the tile exists, we disable the city entry field & plus button.
gustavohandrade
When clicking the "search" and "update" buttons highlighted on the image below, "nothing" happens. The parameters for the search are established, but you need to manually press the search button on the search bar to implement the filters. As is, it seems to the user that the filters do not work. The search should be updated automatically when a filter is applied.