ajah / sks-interface

0 stars 0 forks source link

Reenables & improves city filter #52

Closed psdcode closed 2 years ago

psdcode commented 2 years ago

This PR rebuilds and reenables the city filter. Resolves issues https://github.com/ajah/sks-interface/issues/49 and https://github.com/ajah/sks-interface/issues/34

Other fixes:

To confirm with @brittwitham :

Time spent: 2.5hrs

brittwitham commented 2 years ago

@psdcode the fixes look great, functionality is as expected.

You make some good points about the /count endpoint and adding phrases to the city search - I'll have Gustavo add these as issues. Thanks!

psdcode commented 2 years ago

@psdcode the fixes look great, functionality is as expected.

You make some good points about the /count endpoint and adding phrases to the city search - I'll have Gustavo add these as issues. Thanks!

@brittwitham Sounds good! btw, in the original comment I think I meant OR instead of AND: "Backend seems to use OR on all words within a city search term"