search

ajalt / clikt

Multiplatform command line interface parsing for Kotlin
https://ajalt.github.io/clikt/
Apache License 2.0
2.51k stars 121 forks source link

feat: move NoOpCliktCommand from clikt-mordant to clikt module #526

Closed EchoEllet closed 2 months ago

EchoEllet commented 2 months ago

Move NoOpCliktCommand class from clikt-mordant to clikt module to allow use it for both

I'm uncertain if there is a reason why this class is in the clikt-mordant module though it seems that the class NoOpCliktCommand does not use any Mordant-specific implementation, moving it to the clikt module to allow the use of it when using clikt-core without a breaking change. This should work for both clikt and clikt-mordant.

We might need to update the docs in case something got outdated, or if there is not, we might want to consider documenting this change.

ajalt commented 2 months ago

Good catch! Since this changes the public API, can you run ./gradlew apiDump to update the api files in order for tests to pass?

EchoEllet commented 2 months ago

The task apiDump has been executed, should we update the relevant docs?

ajalt commented 2 months ago

Thanks! None of the docs mention which module it belongs to, so I don't thing anything needs to change there.

Since the core module hasn't been released yet, we don't need to make a changelog entry.

EchoEllet commented 2 months ago

Thank you for merging this PR as well for maintaining the project.