search

ajalt / colormath

Multiplatform Kotlin color conversion and manipulation
https://ajalt.github.io/colormath/
MIT License
308 stars 21 forks source link

Set unique android.namespaces for all the extensions #46

Closed frett closed 1 year ago

frett commented 1 year ago

these values are what were originally set in the AndroidManifest.xml. It doesn't matter too much what they are set to, just as long as they are unique and don't collide with other namespaces

Fixes #45

ajalt commented 1 year ago

Excellent, thank you!

Do you know what the backwards compatibility is for changing these?

frett commented 1 year ago

It would change the location of the BuildConfig class generated for each extension (which actually would revert to the location that was in 3.2.1).But I'm not aware of any use of the generated BuildConfig for those extensions

JakeWharton commented 1 year ago

You should consider disabling the BuildConfig generation. It's off-by-default in AGP 8 for libraries anyway.

frett commented 1 year ago

@ajalt I can add that to this PR if you want

ajalt commented 1 year ago

yes please, if it's not necessary, let's get rid of it

frett commented 1 year ago

I think the namespace change should stay to prevent any future conflicts. I know the R class is also generated under that namespace, but you aren't currently including any android resources that would be affected by that