search

ajalt / mordant

Multiplatform text styling for Kotlin command-line applications
https://ajalt.github.io/mordant/
Apache License 2.0
935 stars 33 forks source link

Support for target linuxArm64 #155

Closed vegidio closed 3 months ago

vegidio commented 5 months ago

Hey, could you please add support for linuxArm64?

ajalt commented 5 months ago

I don't have an arm device, so I wouldn't be able to test it. Does the current linux-specific code work without modification on arm? If so, I would be willing to add that target, but if not, I don't want to add platform-specific code that I never run.

JakeWharton commented 5 months ago

If you follow the Kotlin tiers for native, linux ARM must only compile on CI but may not actually work at runtime 😅

https://kotlinlang.org/docs/native-target-support.html#tier-2

Linux ARM is an important target for embedded and small computing (Raspberry PIs) so I would also suggest it be included.

ajalt commented 5 months ago

Good point. We need https://github.com/JetBrains/markdown/issues/146 to publish an arm artifact first, but I'll add it once they do.

vegidio commented 3 months ago

Apparently now Markdown has a new artifact with support for linuxArm64: https://central.sonatype.com/artifact/org.jetbrains/markdown

ajalt commented 3 months ago

I know; I was the one who added it https://github.com/JetBrains/markdown/pull/147 😉

I'm waiting for the next kotest release which adds wasmJs support, then I'll make a release with both new targets. I could of course work around kotest and release now, but they're planning a new release "soon", so I've just been holding off for that.