Closed joannaskao closed 9 years ago
mhkeller
commented
10 years ago Is there a use case where you would favor read permissions over pushing? The easier to implement is to push at a certain time since that's in the flow of how it works already. So that can be the strategy if it captures everything you wanna do.
joannaskao
commented
10 years ago Pushing would be better than changing read permissions since there are cases where we want to update an existing page at a certain time, so if it's easier, go with that! Changing permissions was just a suggestion.
mhkeller
commented
10 years ago Thank you for responding both verbally across our desks and on the issue tracker.
A MILLION GITHUB POINTS FOR YOU
✨💥🌟✨🌟✨🌟✨🌟💥🌟✨💥💥💥💥💥✨🌟💥💥💥💥💥🌟✨💥💥💥💥💥✨🌟💥💥✨✨🌟💥✨🌟✨🌟✨🌟✨💥✨🌟💥🌟✨🌟💥🌟✨💥✨🌟✨💥✨🌟✨🌟💥🌟✨🌟✨💥💥🌟🌟🌟✨💥✨🌟✨🌟✨💥✨🌟✨💥💥🌟✨💥✨🌟💥💥✨🌟💥🌟✨🌟✨💥✨🌟✨🌟💥💥✨✨✨🌟💥🌟✨🌟✨🌟💥🌟✨🌟💥🌟💥🌟💥🌟✨💥✨💥✨💥✨🌟✨🌟💥🌟✨🌟✨💥💥🌟🌟🌟✨💥✨🌟💥🌟✨💥✨🌟✨💥✨🌟💥💥✨🌟💥🌟✨💥💥🌟✨🌟✨💥✨🌟✨🌟💥💥✨✨✨🌟✨💥✨💥✨💥✨🌟✨🌟💥🌟✨🌟💥🌟✨💥✨🌟✨💥✨🌟✨🌟💥🌟✨🌟✨🌟✨🌟🌟🌟✨🌟✨💥✨💥✨🌟✨🌟✨💥💥💥💥💥🌟✨💥💥💥💥💥✨🌟✨🌟💥🌟✨🌟✨💥💥🌟🌟
mhkeller
commented
10 years ago What would be the ideal date entry format? Something like a full ISO string would be nice but is hard to type.
It could do a few prompts like
Or, perhaps a separate command is called for like `swoop schedule so as to avoid bloating up the prompts?
mhkeller
commented
10 years ago This looks promising: https://github.com/ncb000gt/node-cron Also this but the above looks like it has built-in timezone support, which is great: https://github.com/mattpat/node-schedule
joannaskao
commented
10 years ago I like the prompts. Timezone support might be good, or we can all just agree to use ET since that's where we live now. Swoop schedule might be nice, although I'm only slightly more than indifferent about it.
Another alternative (which I'm not necessarily endorsing as a better option) is to add prompts for date and time within swoop deploy, but make the default the current date and time so people can just press enter and get it to deploy right away.
mhkeller
commented
10 years ago ya those are the two to balance. is the annoyance of an extra prompt in
swoop deploy outweighed by the confusion of a separate command? questions
questions
On Wed, Nov 12, 2014 at 1:52 PM, joannaskao notifications@github.com wrote:
I like the prompts. Timezone support might be good, or we can all just agree to use ET since that's where we live now. Swoop schedule might be nice, although I'm only slightly more than indifferent about it.
Another alternative (which I'm not necessarily endorsing as a better option) is to add prompts for date and time within swoop deploy, but make the default the current date and time so people can just press enter and get it to deploy right away.
— Reply to this email directly or view it on GitHub https://github.com/mhkeller/kestrel/issues/2#issuecomment-62771990.
@mhkeller mhkeller.com
mhkeller
commented
9 years ago This is done in the cli version 0.8.0 https://github.com/mhkeller/kestrel-cli/commit/0905922b0c5c7627a1d0496bff1c24e487b38fa9
mhkeller
commented
9 years ago Finished with commits https://github.com/mhkeller/kestrel/commit/31984acb5d34b09bfc38e103db9b1ebb107e2974 through https://github.com/mhkeller/kestrel/commit/b20c645c90742a4b740e3a633aeda314aeefac2f
Now when publishing you'll have a when prompt in the cli. Add the date YYYY-MM-DD HH:MM format and your push will be scheduled. All times are US/Eastern as defined in kestrel config.json https://github.com/mhkeller/kestrel/blob/master/config.sample.json#L33
You'll get one email confirming that scheduling is set and another email once the push is made.
Create the option to do the push to the server at a later date/time, adding read permissions of the base folder at a certain time or something else I'm not thinking of.