search

ajanata / PretendYoureXyzzy

A web clone of the card game Cards Against Humanity.
https://pretendyoure.xyz/zy
BSD 2-Clause "Simplified" License
1.23k stars 397 forks source link

Adding a game name + fixes to the eclipse build project #116

Closed Vir4030 closed 6 years ago

Vir4030 commented 10 years ago

the first commit, adjust constants to be consistent with repo name, was not entirely good. The final commit, dynamically add project loc, fixes this. That solution was using ${project_loc} as the root path for the builders. The other good changes are to use ${build_project} instead of ${project_loc} for the working directories. Also to have the JRE version be the default rather than hard-coded to 1.7.0_67.

The fun changes are to be able to specify a game name.

ajanata commented 10 years ago

In the future, each feature/fix should be in its own branch and pull request. If one depends on another, base its branch on the dependency's branch and make a note of the merging order in the requests.