search

ajanata / PretendYoureXyzzy

A web clone of the card game Cards Against Humanity.
https://pretendyoure.xyz/zy
BSD 2-Clause "Simplified" License
1.22k stars 397 forks source link

Resolved: Too many played cards will cover hand #135

Closed TwistedAkai closed 9 years ago

TwistedAkai commented 9 years ago

Fixes #1

Drove me nuts on my friend's version. This worked for a quick fix. Probably a better place to put it, but I can't be bothered to look for it. :p

TwistedAkai commented 9 years ago

Looking around more, there would still need to be a CSS fix for still more cards. Setting Max-height might work. It's too late for me to take the fix note out of the commit, but this should work as a stopgap for the average game.

TwistedAkai commented 9 years ago

Thinking more on this, it might have been better to just modify the CSS, if the class of played cards changes when they're revealed. This solution was just internalizing a pair of javascript bookmarks I made.

TwistedAkai commented 9 years ago

Caused issues in NightDevel's code ( #132 ), so I'm going to drop this for now in favor of the new UI.