search

ajanata / PretendYoureXyzzy

A web clone of the card game Cards Against Humanity.
https://pretendyoure.xyz/zy
BSD 2-Clause "Simplified" License
1.23k stars 397 forks source link

Three player game ends if one times out (not just when kicked) in a round #86

Closed LJNielsenDk closed 10 years ago

ajanata commented 10 years ago

Without further details, I'm going to have to call this "working as intended" -- the game cannot be played with 2 players, and there is not currently a way to pause a game with insufficient players. (That could be a feature request, but it'd be pretty low-priority from my standpoint).

LJNielsenDk commented 10 years ago

Wouldn't it make more sense to just drop the round like when the current Czar leave? There are still 3 players so until one gets kicked for inactivity or leave the game can still continue.

uecasm commented 10 years ago

Depends how likely it is that the idle person will come back immediately for the next round. If they were only briefly idle it might work. (But I think two rounds in a row idle = kick, and then you're back to a game reset.)

I think I have a code change floating around in my test server that might have that effect, actually. I'll try to find some time to isolate it. (I was experimenting with disabling the idle timer and letting the host manually elect to skip a player. But that was before #77.)

LJNielsenDk commented 10 years ago

Yes, it shouldn't be long or indefinite (unless a checkbox is added to enable/disable this for a game).

The regular rules would be fine but as it is now the game ends the first round a player is idle rather than the second when they get kicked and there is too few players left to play..