ajanata / PretendYoureXyzzy

A web clone of the card game Cards Against Humanity.
https://pretendyoure.xyz/zy
BSD 2-Clause "Simplified" License
1.23k stars 397 forks source link

Can't read game options while playing game #87

Closed mneimeyer closed 10 years ago

mneimeyer commented 10 years ago

The Game Options box has no background color/is transparent. When you click show game options during a game it is very hard to read (depending on what it overlaps).

Adding a background color to the game_options div fixes this (at least when done manually with the Chrome developer tools)

LJNielsenDk commented 10 years ago

At the start of a game (if you join an ongoing one) it looks correct until you get your hand.

MelissaCole commented 10 years ago

A background color as mneimeyer would be great for this (perhaps the dark gray color at the top?). Making the options window wider would help a little, too. Here you can see the game options overlapping: Game options during game

It can also be an issue at the start of a game (overlaps a little bit at the bottom): Game options at start of game

ajanata commented 10 years ago

I can't reproduce it overlapping the tab bar, probably due to a difference in monitor DPI. I am adding a background color, but it will still overlap the tab bar.

(This is another reason why I've stopped taking new card sets until I can figure out a better UI for this.)

uecasm commented 10 years ago

Possibly a little boring, but you could use a multi-select select box. You can limit the size of that at least. (And it'd be easier to use for the people who want to play with all the decks -- though less so for those who don't.)

ajanata commented 10 years ago

I've been thinking about how I want to change the UI when I finally get around to user-managed custom card sets, and will likely have the card set selection be in a pop-up box have some method to search through the card sets as well. Of course, this is still going to be a little ways in the future due to my lack of time to work on this. =\