ajaxorg / ace

Ace (Ajax.org Cloud9 Editor)
https://ace.c9.io
Other
26.65k stars 5.27k forks source link

Minimap #2655

Open rocketinventor opened 9 years ago

rocketinventor commented 9 years ago

Hi, I've been hard at work on a minimap plugin for C9/ace. The url is https://github.com/rocketinventor/ace-minimap. However, there are some parts that I still haven't gotten/ cannot get worked out and there are a few parts it needs to be functional, so please check https://github.com/rocketinventor/ace-minimap/issues to see how you can help. Please do clone, fork, star, commit, and pull request. Thanks, -Elliot

mlajtos commented 9 years ago

Hey! Is there any demo available?

rocketinventor commented 9 years ago

No, sorry. I haven't gotten it to do anything useful, so no demo available. I would like to get a functional build out asap but, I am having problems getting certain things to work. You can git clone to the plugins repository to try out the current work, though.

OmlineEditor commented 9 years ago

I can't install the plugin for Cloud9: Failed to upload new package to API - Validation failed

map

rocketinventor commented 9 years ago

@OmlineEditor Why are you trying to upload it?

OmlineEditor commented 9 years ago

I add a package from the list (you can check by command: c9 list). after I wanted to install command: c9 install "Ace Minimap". what am I doing wrong? how to install other plugins. please help

rocketinventor commented 9 years ago

Oh, I don't know about the list. I never added ace-minimap to it so I wouldn't suggest trying to install it that way yet. Neither ace's plugin system, nor this plugin are quite ready for primetime yet. Sorry (all help is welcome, though).

github-actions[bot] commented 2 years ago

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

OmlineEditor commented 2 years ago

do not delete

ldijkman commented 11 months ago

Ace minimap?

https://github.com/ldijkman/Ace_MiniMap/tree/main/docs

269827684-0b4c9f3a-6d8d-4879-ab6d-c148f4b624fb

marinsokol5 commented 11 months ago

Nice work! We do have Ace extension folder, in case you want to share it with others https://github.com/ajaxorg/ace/tree/master/src/ext by opening us a PR.

@nightwing is this something that we would be interesting from a feature perspective?

whazor commented 11 months ago

Also, it would be better to use static_highlight.js instead of a full-fledged ace-editor because the minimap does not need any editing features, so static highlighting would be more optimal.

ldijkman commented 11 months ago

made a few small changes not perfect, but works a bit better

https://ldijkman.github.io/Ace_MiniMap/ace_editor_minimap.html

2023-09-22-220255_1920x1080_scrot

andredcoliveira commented 11 months ago

This is a very useful contribution! I think a lot of people expect or at least want this feature from an editor nowadays.

Would you be able to open a PR on this repository, @ldijkman, as @marinsokol5 suggested above?

Also, a few notes after playing around with https://github.com/ldijkman/Ace_MiniMap/tree/main/docs, mostly from a UI/UX perspective:

ldijkman commented 11 months ago

Think this one ads an minimap to the editor

https://ldijkman.github.io/Ace_Seventh_Heaven/Hell.html

positioning the minimap immediately adjacent to the main editor's scrollbar could economize horizontal space
currently, there is some space between the minimap and the scrollbar that I imagine isn't effective to use
I'm a bit torn on being able to interact with the text on the minimap, probably because of familarity with VSCode's minimap.

widt heigtht position space size can be changed by css

I would suggest, if possible, to turn the minimap into one big scrollbar, though I'm not sure if Ace allows for that at this moment

that is possible like the custom vertical scrollbar but i did grey view part easy for now

positioning the cursor on the minimap places it in the same position in the main editor, but the opposite doesn't seem to be true
positioning the cursor in the main editor doesn't results in offset lines being selected in the minimap

scrolling sets the view should display current line?

should display doubleclickselect and search highlights in minimap

want to remove scrollbar from behind customscrollbar but i want the minimap scrollbar different from vs monaco but i like the minimap scrollbar

it is a very basic example lots could be improved

in visualstudio monaco a find/search result selection highlight is not cleared by a mouseclick in editor ace cleares the search highlighted results i would like to leave them highlighted anyone knows how to change that?

https://ldijkman.github.io/Ace_Seventh_Heaven/Hell.html Hell

TimChinye commented 3 months ago

Also, it would be better to use static_highlight.js instead of a full-fledged ace-editor because the minimap does not need any editing features, so static highlighting would be more optimal.

Highly agree with this! Plus, let’s talk about the minimap’s look—it’s just not doing it for me. Sure, you can tweak it with some CSS magic, but the out-of-the-box style isn’t exactly inviting.

Also, there’s this quirky thing in the demo where the cursor’s line marker on the minimap snaps to where you click, but then it hops up a line right away. Definitely a bug, but honestly, it’s one we could do without if the highlight just stayed put.

With the limited availability for solid minimap extensions, I’m skipping the minimap feature for my project’s first version. When it’s time for updates, I’ll circle back to see if the "Ace Minimap" has stepped up its game. If not, it might be DIY time for me.