search

ajaxorg / ace

Ace (Ajax.org Cloud9 Editor)
https://ace.c9.io
Other
26.76k stars 5.29k forks source link

Nice project, but inherently broken #3448

Closed hypersoft closed 7 years ago

hypersoft commented 7 years ago

You have embedded styling of the editor within the code. That is a no-no. If you don't correct this issue immediately your problem will only get bigger.

This bug prevents the implementor from employing the editor within their own interfaces. I am not sure why the developers have taken this route, but I am sure it must be of some necessity in rendering. Unfortunately, this requirement of the editor to be the boss of placement within the document, renders the current implementation unsatisfactory due to design restrictions. You should consider some type of container element that you will render all of your content within, so that the implementor may place the editor within their user interface however they see fit.

I have tried to go in and modify the code myself, but the editor code is too adamant about controlling the display to continue working as designed.

So here is the catch:

http://bl.ocks.org/jfsiii/5380802

I am struggling to place the editor within the article area of the above template, and the status bar within the footer element. They certainly will not play nicely together, and this is just a testament to the poor design guidelines by this project, because the editor instance will not respect the container that it is placed within.

hypersoft commented 7 years ago

for future reference, styling anything other than internal controls, and syntax is taboo. You have to leave all design up to the person placing the editor within the page/document. When you don't do this, you are engaging in bad behavior and your project will not optimally scale.

It is much better for your code to awesomely fail because someone using the code didn't do something correctly, than to force them to do things a certain way. In this manner, workarounds for design deficiencies can be explored without modifying your code.

nightwing commented 7 years ago

Could you show a code example of what you mean. Ace works with the template you are showing https://plnkr.co/edit/p1jFZLuUPxhOnAg8EVYB?p=preview

hypersoft commented 7 years ago

Thank you for that! Unfortunately I do not have the test code I was using. But I have observed that you used DIV elements to contain the code and you set the height property of the editor, and that is not what I was doing.

I seriously cannot express my grattitude for your quick response with your knowledge and expertise in this matter.