Closed akoreman closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.89%. Comparing base (
ed233cf
) to head (b60cd72
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issue #, if available: NA
Description of changes: In the ghost text, we set the content of a line as the text content of a div. For lines without any text (e.g. when the suggestion has a line of white space) this results in a div without any contents, which most browsers will not render. This change sets a space as the text content if it's empty to ensure the empty lines get rendered.
Before this change:
https://github.com/user-attachments/assets/7c03e522-b978-4ed9-9f28-ea4b7eb9cf1e
After:
https://github.com/user-attachments/assets/f3f3b371-3e83-4c28-938b-cbd18310e5f2
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts
) and its references: