search

ajaynegi45 / Investment-Calculator

This tool allows you to easily calculate the how much investment is required to reach a desired income goal based on the dividend yield.
https://tools-45.web.app/
MIT License
6 stars 3 forks source link

Dark Mode is not working #1

Closed ajaynegi45 closed 10 months ago

ajaynegi45 commented 10 months ago

when dark mode is activated You need to invest: text is not visible

khushalmajoka commented 10 months ago
image

I guess it is working fine. What's the issue?

ajaynegi45 commented 10 months ago

@khushalmajoka

when light mode is activated Everything works properly.

Screenshot 2023-10-05 at 2 35 52 PM

but in dark mode "You need to invest:" text below the Calculate button is not visible

Screenshot 2023-10-05 at 2 36 00 PM
khushalmajoka commented 10 months ago

Okay got it, let me fix it.

khushalmajoka commented 10 months ago

@ajaynegi45 how do you locally run the project on you machine, because when I ran in the chrome I am not getting the option for light and dark mode.

image
ajaynegi45 commented 10 months ago

@ajaynegi45 how do you locally run the project on you machine, because when I ran in the chrome I am not getting the option for light and dark mode.

image

Hi @khushalmajoka ,

I apologize for any inconvenience you experienced earlier. I'm pleased to inform you that I have worked on the issue you mentioned, and it has been fixed.

You can now try running the project locally again, and you should have the option to switch between light and dark modes. If you encounter any further issues or have additional questions while running the project, please don't hesitate to reach out. Your feedback is valuable to us, and we're here to assist you.

khushalmajoka commented 10 months ago

Thanks a lot @ajaynegi45

khushalmajoka commented 10 months ago

@ajaynegi45 There are still issues with the index.html file I guess, please check:

image

Also Dark mode option is available but still not working.

image
roniskywalker commented 10 months ago

Hello ajaynegi45, I have fixed this issue. Please do check.

ajaynegi45 commented 10 months ago

Hi @khushalmajoka ,

I apologize for any inconvenience you experienced earlier. I'm pleased to inform you that I have worked on the issue you mentioned, and it has been fixed.

You can now try running the project locally again, and you should have the option to switch between light and dark modes. If you encounter any further issues or have additional questions while running the project, please don't hesitate to reach out. Your feedback is valuable to us, and we're here to assist you.

Hi @khushalmajoka ,

I apologize for any inconvenience you experienced earlier. I'm pleased to inform you that I have worked on the issue you mentioned, and it has been fixed.

You can now try running the project locally again, and you should have the option to switch between light and dark modes. If you encounter any further issues or have additional questions while running the project, please don't hesitate to reach out. Your feedback is valuable to us, and we're here to assist you.

ajaynegi45 commented 10 months ago

Hello ajaynegi45, I have fixed this issue. Please do check.

Not working

khushalmajoka commented 10 months ago
image
khushalmajoka commented 10 months ago

@ajaynegi45 why have you closed the PR?? It fixes the issue very well.

ajaynegi45 commented 10 months ago

@ajaynegi45 why have you closed the PR?? It fixes the issue very well.

https://github.com/ajaynegi45/Investment-Calculator/pull/8#pullrequestreview-1661231192

khushalmajoka commented 10 months ago

Okay i can resolve this too. If you say I will?

ajaynegi45 commented 10 months ago

Okay i can resolve this too. If you say I will?

yes you can resolve this issue

khushalmajoka commented 10 months ago

Can u please reopen the PR?

khushalmajoka commented 10 months ago

or i will have ti create a new one.

ajaynegi45 commented 10 months ago

or i will have ti create a new one.

create new PR

ajaynegi45 commented 10 months ago

You can checkout our more project to contribute Library