search

ajaynegi45 / LibraryMan-API

Revolutionize book management with LibraryMan! Easily track stock, borrowers, and due dates, streamlining operations for schools, companies, and libraries worldwide, ensuring efficient and organized book lending.
MIT License
12 stars 4 forks source link

updated code structure with with neat file system and provider logger #8

Closed Prasadpoojary closed 8 months ago

Prasadpoojary commented 11 months ago

Hi Team,

I observed that the written code style looks very disturbed since it has different file for each method. To achieve readability and code maintainability its important to have it properly structured. I have done this proper code structure in this repo, maintained proper exception handing terminology and added logger. Feel free to merge.

Thanks, Prasad, Coder

ajaynegi45 commented 8 months ago

Hi Team,

I observed that the written code style looks very disturbed since it has different file for each method. To achieve readability and code maintainability its important to have it properly structured. I have done this proper code structure in this repo, maintained proper exception handing terminology and added logger. Feel free to merge.

Thanks, Prasad, Coder

Hi @Prasadpoojary ,

Thanks for taking the initiative to improve the code structure. I appreciate your effort in enhancing readability and maintainability. However, after reviewing the changes, I noticed that the modifications made do not align with the SOLID principles, which are crucial for our codebase.

In order to ensure the long-term scalability and flexibility of our software, it's essential to adhere to SOLID principles. I recommend revisiting the code adjustments with these principles in mind. Once the changes align with SOLID principles, we can consider merging them into the main codebase.

Feel free to reach out if you have any questions or if you'd like further clarification on SOLID principles.

Thanks