search

ajaynegi45 / Uttarakhand-Culture-NewUI

Unlock Uttarakhand's hidden treasures! Discover its vibrant culture, rich history, and breathtaking beauty. Join our mission to preserve and celebrate the region's heritage for future generations.
https://uttarakhand-culture.vercel.app
27 stars 67 forks source link

[FEATURE] JSON file to store data for Trekking Page #77

Open ShivamPande18 opened 1 month ago

ShivamPande18 commented 1 month ago

Is this feature already requested?

Problem or Missing Functionality

The data of most of the pages is hardcoded. Also the images in most of them are just placeholder images. Adding new data is not dynamic and difficult

Feature Description

I suggest that we can create separate JSON files(to start with, later to make it more accessible for the users to add data we can create a proper backend) that can hold data for trekking, languages, food, etc pages and modify the code to dynamically add the data on to the page.

Screenshots

image

Would you like to work on this feature?

Yes

Implementation Plan

github-actions[bot] commented 1 month ago

👋 Thank you @ShivamPande18 for raising an issue! We appreciate your effort in helping us improve. Our team will review it shortly. Stay tuned!

ajaynegi45 commented 1 month ago

Is this feature already requested?

  • [x] I have checked "open" and "closed" issues, and this is not a duplicate.

Problem or Missing Functionality

The data of most of the pages is hardcoded. Also the images in most of them are just placeholder images. Adding new data is not dynamic and difficult

Feature Description

I suggest that we can create separate JSON files(to start with, later to make it more accessible for the users to add data we can create a proper backend) that can hold data for trekking, languages, food, etc pages and modify the code to dynamically add the data on to the page.

Screenshots

image

Would you like to work on this feature?

Yes

Implementation Plan

  • Create a JSON file with data for a particular page
  • Read the JSON in the trekking page (src\app\trekking\page.tsx)
  • create a map of data
  • loop through all the items to display data dynamically

Hi @ShivamPande18,

Thank you for expressing your interest in working on this issue. I'm delighted to inform you that I have assigned this issue to you. Your willingness to contribute to our project is much appreciated.

Before making any contributions, please read the Readme.md file carefully to better understand the project's goals and purpose. This will give you clarity on our mission. Also, make sure to review the Contributing.md file, which contains important guidelines to make the contribution process smoother, especially for newcomers.

Feel free to start working, and if you have any questions or need assistance during the process, please don't hesitate to reach out.

ShivamPande18 commented 1 month ago

@ajaynegi45 Created a Pull Request implementing the feature.

ajaynegi45 commented 1 month ago

@ajaynegi45 Created a Pull Request implementing the feature.

Resolve the error https://github.com/ajaynegi45/Uttarakhand-Culture-NewUI/pull/84#pullrequestreview-2349932698

IkkiOcean commented 1 month ago

@ajaynegi45 Can you please assign me this issue? As this issue has be stale for more than a week. I'm very much aware of how to solve it and can PR in one day.