search

ajayyy / DeArrow

Crowdsourcing better titles and thumbnails on YouTube
https://dearrow.ajay.app
GNU General Public License v3.0
1.41k stars 38 forks source link

A Turkish letter "İ" looks creepy. With replace title option. #118

Closed sertchan closed 1 year ago

sertchan commented 1 year ago

It looks like this. image

While it should looks like this. image

Turkish has a capital letter 'İ' which is not present in English, and when reformatting the titles with this extension, it strangely converts this letter to a 'i̇' instead of 'i'. It looks kinda weird.

ajayyy commented 1 year ago

This is the behavior of the toLowerCase function in the browser.

It converts it into an i character followed by a "COMBINING DOT ABOVE" unicode modifier

i\u307 i ̇ which becomes i̇, not to be confused with i

I wonder if there is a special reason for that, or just an issue with the standard

and then maybe YouTube's default font is drawing it incorrectly

sertchan commented 1 year ago

I thought "If its related to browser (which i use Firefox) changing browser could solve the problem temporary". Then i tried with chromium. image image It's not perfect but looks better. Thus, I can say its a bug related to Javascript's toLowerCase function. Maybe using other methods before toLowerCase function like replace function with switch case or regex can solve the problem.

sertchan commented 1 year ago

Also in Turkish we've capital "I" in turkish titles it looks like: image

Same as "I" in english but it's a different letter so with extension the title should be like this: image

But extension currently shows this: image (Look the word "Aşşağılandım")

I suggest you take a look at this. Good Evenings :)