Add ☆ to cleanEmoji regexes and fix overlapping matches - Githubissues

ajayyy / DeArrow

Crowdsourcing better titles and thumbnails on YouTube

https://dearrow.ajay.app

GNU General Public License v3.0

1.4k stars 37 forks source link

Add ☆ to cleanEmoji regexes and fix overlapping matches #213

Closed SuperStormer closed 9 months ago

SuperStormer commented 9 months ago

[yes] I agree to license my contribution under LGPL-3.0 or my contribution is from another project with a license compatible with LGPL-3.0

To test this pull request, follow the instructions in the wiki.

fix for https://www.youtube.com/watch?v=7lpZ_dEvLSs

Added "☆" (U+2606) to the regexes, because it's not tagged as Extended_Pictographic, even though "★" (U+2605) is.
Changed the "emojis in between letters" regex to use a lookahead for the second letter, in order to allow matches to overlap. This fixes letter-emoji-letter-emoji-letter cases such as "R☆T☆R".

ajayyy commented 9 months ago

nice