ajayyy / SponsorBlock

Skip YouTube video sponsors (browser extension)
https://sponsor.ajay.app
GNU General Public License v3.0
9.83k stars 320 forks source link

Design problem: People are being harmfully imprecise in their segment timings. #1477

Open navid-zamani opened 2 years ago

navid-zamani commented 2 years ago

I just came from a video, where the blocked segment was done so lazily, that it skipped the entire point of the video in that final sentence. Giving the video a different tone from what the creator intended.

This happens more and more, as more people start using the service.

So this issue serves to put forth the idea, to redesign the service and UI to make it impossible to submit not frame-perfect segments, and account for imprecision

My suggestion for how this can comfortably established, is by having the “start segment” and “end segment” triggers pause the video and present a UI that asks the user to position the marker exactly at the first/last frame of it, using the “,” and “.” keys (which are standard on YT, and which I already use each time I submit a segment). To make it nicer, when the user uses the triggers while not paused, the marker’s initial position should be a few frames earlier to account for the lag in human reaction, and to have the user go “That’s not right!” and hence motivate them to want to correct the UI’s “mistake”.

Additionally, I want to suggest checking out the algorithm that Streamripper for WinAMP used to find the cutting position between songs. As that worked quite well and has been tested and reliably working for a long time. (Essentially, it does not trust the trigger entirely, but in a certain area around what it was told is the cutting point it searches for the most quiet point, to cut there, in a way that both halves keep a bit of overlap that was found to be necessary to account for unusual situations. For the video part, that would be the same algorithm as video cutting programs use to detect scene changes. But the question is if SponsorBlock can even read the video data at all. … In any case it can implement the “overlap” idea, and always play the video a bit longer/earlier than the segment start/end, for a quick fix to already submitted segments.)

mirror176 commented 1 year ago

Definitely a fan of quality edits. Please downvote, or better yet, downvote+reedit bad edits. If edits get sloppy enough that it causes content related issues and seems more than a 1-off or seems to be completely wrong edits, I currently try to bring it up on discord; hope one of the humans in power can find any edits that are truly detrimental to communicate issue to user or one I reported where categories were randomly marked and obviously incorrect like 'non music section of music video' used in a video that was in no way a music video among the many errors they had in their marking that time. My understanding is that sponsorblock does not look at/access audio/video during the edit. If wrong then I shall dream where precise editing comes to sponsorblock. Requiring ,/. be used would not make sense. Not all edits have a clear 'this frame good, that frame bad' edge to it, nor is it always necessary. Mousewheel also works when editing as does editing the time itself though I do not know how a mousewheel adjustment compares in terms of frames as frames are a different fraction of a second than the mousewheel numerical adjustment and my mousewheel is failing so I cannot reliably test or use it anyways. Some videos get edited (=content cut) after being put on youtube. If it is anything other than trimming the end, timings following the cut will be incorrect. I do not recall if the video length is noted with the edits to flag 'these may be bad now' if a video comes thorough at a different length but that would be a way to help resist it or make user aware of potential issues. If the skip happens in general sooner or later than the marked location as an attempt to fix the bad edits you saw, many edits I have made and see from others would now be noticeably incorrect. Starting the cut sooner causes undesired content to be lost and starting the cut later causes undesired content to be leaked. Cutting either way can be quite distracting. In an attempt to create clean edits I will leak a little bit of the transition rather than cut out words from a sentence (presuming its not fluff like 'so' at the start of a sentence). I have gone as far as two midsentence cuts on a youtuber's content as the sentence was repeated around a sponsor after they cut the sponsor into it because they copied that sentence before+after the cut. I didn't mark start or end of sentence as they had transition over end of sentence to start sponsor and over start of sentence to end sponsor. I was able to find a visual frame between words to reliably mark a start/stop which causes a slight hiccup visually due to the seek taking place but overall seemed cleaner and less distracting than a partial transition that is cutoff on its start or end both visually and audibly.