search

ajayyy / SponsorBlock

Skip YouTube video sponsors (browser extension)
https://sponsor.ajay.app
GNU General Public License v3.0
10.29k stars 325 forks source link

Support for cytube. #150

Closed Azunyan- closed 2 years ago

Azunyan- commented 5 years ago

I'm mostly asking about support for their site: https://cytu.be/ altough they are open source and one could add support via their backend and make a fork. I'm guessing the leader of the room is going to have the addon installed since it is the leader that is in charge of how to video is synced.

ajayyy commented 5 years ago

This site uses YouTube embeds right? If so, it should work.

Azunyan- commented 5 years ago

Yeah it uses YouTube embeds, it hasn't worked for me before but does now. I just doubled checked on a video that does have sponsorship that are marked on YouTube (LTT).

Queueing the video and me being the leader does skip it, but if I queue another video with sponsorship in it will retain the same skip points from the past video and incorrectly skip in the second video.

ajayyy commented 5 years ago

Oh sorry, I forgot about that issue. Someone else has mentioned it before. The issue is that it currently looks at the URL of the frame, which remains constant even when the video changes. So, it only works for the first video. This one is a little harder to fix.

ajayyy commented 4 years ago

durationchange listener

ajayyy commented 4 years ago

Cytube seems to just be resetting the timstamp anyway. I don't thinking fixing it showing the wrong sponsors will help.

Azunyan- commented 4 years ago

You need to be the room leader to make sure your local change of the current time in the video is the one the room follows and it will keep it from resetting. This means that only the room leader needs the add-on installed.

ajayyy commented 4 years ago

I was the room leader and couldn't get that to happen.

On Wed, Feb 19, 2020, 4:21 PM Azunyan- notifications@github.com wrote:

You need to be the room leader to make sure your local change of the current time in the video is the one the room follows and it will keep it from resetting. This means that only the room leader needs the add-on installed.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ajayyy/SponsorBlock/issues/150?email_source=notifications&email_token=ADAZV4CZSDHMGWPGOPCRHDDRDWPHDA5CNFSM4IUMDAVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMJXE5Q#issuecomment-588477046, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADAZV4HOV5XOV2KIG5DMC6TRDWPHDANCNFSM4IUMDAVA .

Azunyan- commented 4 years ago

I just tried it and it worked for me in a room with only me in it. The video successfully skipped the first two "ads/sponsorships" in the video and continued playing without resetting to the prior point before the ads. I was the room leader. The room is registered to my account on cytube. I'm running Firefox 71.0 (64-bit) SponsorBlock Version 1.2.13 . Video I used to test this: https://www.youtube.com/watch?v=4DKLA7w9eeA

I can't think of anything else that might be relevant for you to try and replicate this but do ask if you want more info or a .gif of me skipping an ad.

I was the room leader and couldn't get that to happen. … On Wed, Feb 19, 2020, 4:21 PM Azunyan- @.***> wrote: You need to be the room leader to make sure your local change of the current time in the video is the one the room follows and it will keep it from resetting. This means that only the room leader needs the add-on installed. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#150?email_source=notifications&email_token=ADAZV4CZSDHMGWPGOPCRHDDRDWPHDA5CNFSM4IUMDAVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMJXE5Q#issuecomment-588477046>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADAZV4HOV5XOV2KIG5DMC6TRDWPHDANCNFSM4IUMDAVA .

Kommynct commented 3 years ago

Since this is very broken right now, is there any way to disable sponsorblock just for cytu.be?

I can't seem to find anything online.

I am on firefox if that helps

edit: sorry, I saw this RIGHT AFTER I LEFT MY COMMENT: https://github.com/ajayyy/SponsorBlock/issues/554

ajayyy commented 2 years ago

Fixed by https://github.com/ajayyy/SponsorBlock/pull/1116