search

ajayyy / SponsorBlock

Skip YouTube video sponsors (browser extension)
https://sponsor.ajay.app
GNU General Public License v3.0
10.24k stars 323 forks source link

Chapter tree displayed in the wrong order #1590

Open melissis opened 1 year ago

melissis commented 1 year ago

This video: https://www.youtube.com/watch?v=kyGR47nDrus At 2:13, the seekbar says: image

That is:

Prep [chapter generated by YouTube]
Cleaning multiple shoes [SB sub-chapter]
Dust off with dry towel [SB sub-chapter]

But it should say:

Prep [chapter generated by YouTube]
Mixed Fabric Shoes [SB chapter]
Dust off with dry towel [SB sub-chapter]

Chapter generated by YouTube: 2:13 - 4:03 Prep SB Chapter: 1:37 - 4:02 Mixed Fabric Shoes SB Sub-chapter: 1:55 - 2:13 Cleaning multiple shoes SB Sub-chapter: 2:13 - 2:23 Dust off with dry towel

I wish we could undo the auto-generated chapters here, they are not helpful.

ajayyy commented 1 year ago

Hmm, why should the middle one be removed?

melissis commented 1 year ago

Hmm, why should the middle one be removed?

Sorry, it was difficult to communicate the problem.

The middle one ("Cleaning multiple shoes") ends (at 2:13) where the third one ("Dust off with dry towel") begins (at 2:13); they do not overlap, but the tree makes it seem like the third one is a sub-chapter of the second one. They are both sub-chapters (on the same level) to "Mixed Fabric Shoes" (SB) and "Prep" (YT). So I would have expected "Mixed Fabric Shoes" to be on the second line.

melissis commented 1 year ago

Another weird one. image "Mest uppspelade igen" = "Most replayed" Wrong sub-chapter displayed here. It should be #2 Plow Point Diamond Fold.

image Moving the cursor a few millimeters to the right....

ajayyy commented 1 year ago

To clarify, the chapter name rendering is based on the time displayed

melissis commented 1 year ago

To clarify, the chapter name rendering is based on the time displayed

Okay. So, the problem is, I think, that at 2:13 (in my first example), one chapter begins ("2:13 - 2:23 Dust off with dry towel") and another ends ("1:55 - 2:13 Cleaning multiple shoes") at exactly that point. So, when hovering over 2:13, it displays one on top of the other. It shouldn't do that. And I don't think it does that normally, it only happens in these cases where YouTube also wants to put some text there (like "2:13 Prep"). The only cases where it is reasonable to display chapters on top of eachother is when there is overlap.

In my second example, the chapter that it renders have already ended some seconds prior.