search

ajayyy / SponsorBlock

Skip YouTube video sponsors (browser extension)
https://sponsor.ajay.app
GNU General Public License v3.0
9.27k stars 300 forks source link

Settings are reset when browser is closed #1816

Open HunterAP23 opened 11 months ago

HunterAP23 commented 11 months ago

I use Vivaldi (a Chromium fork), and whenever I close out the browser, the SponsorBlock settings get reset to the defaults. I personally just use SponsorBlock to highlight the segments in the video player bar and skip manually, but when I close the browser and the settings return to the defaults, then segments are automatically skipped even if I don't want them to be.

I do not have any settings enabled to clear cookies or other data when the browser is closed, this just seems to happen on it's own.

jakche commented 10 months ago

@ajayyy Same stuff I mentioned #1825 happens to this lad, only with SponsorBlock the #180 doesn't seem to fix my problem it talks about Firefox.

jakche commented 10 months ago

I use Vivaldi (a Chromium fork), and whenever I close out the browser, the SponsorBlock settings get reset to the defaults. I personally just use SponsorBlock to highlight the segments in the video player bar and skip manually, but when I close the browser and the settings return to the defaults, then segments are automatically skipped even if I don't want them to be.

I do not have any settings enabled to clear cookies or other data when the browser is closed, this just seems to happen on it's own.

Have you done any Windows debloating, costum ISOs?

HunterAP23 commented 10 months ago

I use Vivaldi (a Chromium fork), and whenever I close out the browser, the SponsorBlock settings get reset to the defaults. I personally just use SponsorBlock to highlight the segments in the video player bar and skip manually, but when I close the browser and the settings return to the defaults, then segments are automatically skipped even if I don't want them to be.

I do not have any settings enabled to clear cookies or other data when the browser is closed, this just seems to happen on it's own.

Have you done any Windows debloating, costum ISOs?

I haven't done any debloating or the like. At most I DDU my GPU drivers in safe mode every once in a while to install the newer ones cleanly, but otherwise it's all stock.

OldaysStudios commented 8 months ago

This keeps happening for me on Safari, not 100% of the time but when the browser is closed and re-opened the settings reset, might be something to do with the new profiles feature since it's the only extension where the settings seem to be the same on all of them, could be a conflict

ajayyy commented 8 months ago

new profiles feature

I don't see anything special about profiles on https://developer.apple.com/documentation/safariservices/safari_web_extensions, so I don't think it's something you can necessarily configure on the extension side. Could you specify the specific extensions that have different settings on each profile? If they are open source, I can take a look at their code to see if they do something different.

OldaysStudios commented 8 months ago

new profiles feature

I don't see anything special about profiles on https://developer.apple.com/documentation/safariservices/safari_web_extensions, so I don't think it's something you can necessarily configure on the extension side. Could you specify the specific extensions that have different settings on each profile? If they are open source, I can take a look at their code to see if they do something different.

the only other extensions i'm using are dark reader, hover and ad guard, i'm not sure if ad guard's settings differ since i didn't have a need to configure it but dark reader and hover definitely have their own settings per profile

OldaysStudios commented 8 months ago

Update: settings reset every time the browser is closed now, and sometimes the settings refuse to save outright unless reinstalled, but then break again after a restart

SINE commented 7 months ago

The issue was happening for me on Firefox 115.5.0esr (64-bit) as well. I found out it was related to the files in the profile folder (appdata roaming)

storage-sync-v2.sqlite storage-sync-v2.sqlite-shm storage-sync-v2.sqlite-wal

Make sure these files are writable (not read-only or otherwise blocked) and not reset between sessions through third party software.

Bluewave2 commented 5 months ago

Settings don't "stick" on chrome, each change of a dropdown in behavior category (I tried to set Intermission/Intro Animation to auto skip) seems to be set but as soon as I close the settings tab and reopen it, the settings are back to before the change. During segment submission it asks to turn on the category in settings, then it works and segment can be submitted but upon reload of tab the setting is (presumably) read but the old setting (off) is applied so I have to turn it on again. Seems to be an issue with data persistence, I think the fix should be pretty simple since it reads old settings fine just doesn't seem to write new settings.

ajayyy commented 5 months ago

@Bluewave2 that is a different bug that will.bevfixed in 5.5.2