Closed Iaotle closed 1 year ago
I have the same problem
Same here
Browser? Is it always, sometimes? Or rarely? List extensions or userscripts installed
Every single time on first video open. Extensions:
ahfgeienlihckogmohjhadlkjgocpleb : Web Store : version 0_2
bigefpfhnfcobdlfbedofhhaibnlghod : MEGA : version 4_42_1
cjpalhdlnbpafiamejdnhcphjbkeiagm : uBlock Origin : version 1_51_0
fdpohaocaechififmbbbbbknoalclacl : GoFullPage - Full Page Screen Capture : version 7_12
fmkadmapgofadopljbjfkapdkoienihi : React Developer Tools : version 4_28_0
gamlckmepdclkglolaedeigblmmpmfhf : Dark theme for VK.COM | Night Mode for Vkontakte™ : version 3_4_0_1
gbaokejhnafeofbniplkljehipcekkbh : Tab Organizer : version 4_3_1
gebbhagfogifgggkldgodflihgfeippi : Return YouTube Dislike : version 3_0_0_10
ghbmnnjooekpmoecnnnilnnbdlolhkhi : Google Docs Offline : version 1_62_0
gmmnidkpkgiohfdoenhpghbilmeeagjj : Sci-Hub X Now! : version 0_2_2
hbdmelobmfcompinikjdaiphhonbgfpn : Youtube™ Actual Top Comments : version 1_3
hoboppgpbgclpfnjfdidokiilachfcbb : VkOpt : version 3_0_8_3
hompjdfbfmmmgflfjdlnkohcplmboaeo : Allow Right-Click : version 1_5_2_4
kbmfpngjjgdllneeigpgjifpgocmfgmb : Reddit Enhancement Suite : version 5_22_17
kmendfapggjehodndflmmgagdbamhnfd : CryptoTokenExtension : version 0_9_74
ldipcbpaocekfooobnbcddclnhejkcpn : Google Scholar Button : version 3_2
mhjfbmdgcfjbbpaeojofohoefgiehjai : Chrome PDF Viewer : version 1
mnjggcdmjocbbbhaepdhchncahnbgone : SponsorBlock for YouTube - Skip Sponsorships : version 5_4_13
neajdppkdcdipfabeoofebfddakdcjhd : Google Network Speech : version 1_0
nkeimhogjdpnpccoofpliimaahmaaome : Google Hangouts : version 1_3_18
nmmhkkegccagdldgiimedpiccmgmieda : Chrome Web Store Payments : version 1_0_0_6
ofbbahodfeppoklmgjiokgfdgcndngjm : TTV LOL : version 0_0_0_3
oiaejidbmkiecgbjeifoejpgmdaleoha : Stylebot : version 3_1_3
okfiigkfppbpfjaiffmllkkfbpdnhofn : ytb not-interested button : version 0_1_1
ponfpcnoihfmfllpaingbgckeeldkhle : Enhancer for YouTube™ : version 2_0_117_1
I don't think I have any userscripts. Running
CHROME VERSION | 104.0.5112.81 |
---|---|
OS VERSION | Windows NT: 10.0.22000 |
Browser? Is it always, sometimes? Or rarely? List extensions or userscripts installed
Firefox Happens most of the times (if not all)
Youtube-related extensions:
Also, when this happens, I can make the extension skip the segment (when I'm currently watching that segment) by hitting the refresh segments button. Enabling/disabling skipping doesn't help.
Also, if I go back the video before the segment starts, then it skips.
Can you send your enhancer settings
Can you send your enhancer settings
I am getting the same thing, I'm running the following extensions
Alternate Player for Twitch.tv
Bypass Paywalls
Redirector
SponsorBlock
uBlock Origin
And here's some console errors when it happened
I'm not getting any sponsorblock errors and even if I disable everything it's still not skipping.
I'm not getting any sponsorblock errors and even if I disable everything it's still not skipping.
same no errors
Can you go to options -> import/export -> copy debug info
Same issue for me. Firefox, Linux, only youtube extension is "Tweaks for Youtube", I don't run Enhancer or anything else like that. I do run DeArrow though
Is there a specific pattern to when it appears. Is it when opening videos in new tabs with the middle mouse button? Or when clicking videos from the homepage? Or only when directly visiting a video from a URL in the browser.
Is there a specific pattern to when it appears. Is it when opening videos in new tabs with the middle mouse button? Or when clicking videos from the homepage? Or only when directly visiting a video from a URL in the browser.
most of the times I open videos in new tab. This tends to break some Youtube addons now that I think about it
I've been running into this issue very frequently recently. I know it happens when I CTRL+click to open a video in a new tab as I usually do, but I haven't thoroughly tested other cases.
Is there a specific pattern to when it appears. Is it when opening videos in new tabs with the middle mouse button? Or when clicking videos from the homepage? Or only when directly visiting a video from a URL in the browser.
Perfect, I think my fix will work then, thanks!
I always open my videos via Middle Mouse Click to a new tab, as I use Inoreader to manage my subscriptions
Let me know if it is still happening in 5.4.15
@ajayyy yep it's still happening in 5.4.15 Noticed this behavior from SB:
Here is debug info:
@Iaotle are there errors in the console?
None related to Sponsorblock. Just errors from adblocker and the like. You can contact me on discord if u wanna debug it at some point, same username.
I'm getting this on 5.4.15 as well. I open videos with middle click almost exclusively, but I just had it happen on a video where I didn't. No error in console, and I do see the sponsor spot, but I only check when I notice its not skipping.
Debug:
@staridiot
can you install this (disable the original) and try to reproduce the issue.
Then send me the console logs along and the order of videos you clicked
https://github.com/ajayyy/SponsorBlock/wiki/Chromium-Unpacked-Install#install-the-extension
You can email it if you want (dev @ ajay. app)
@ajayyy
Unfortunately, I cannot. Chrome does not work for me, videos don't load at all. Its not related to SponsorBlock, I have no idea why it won't load and have very little interest in fixing it. I use Firefox as my main browser, if you can give me a debug build for Firefox I can test it.
@staridiot You can load this in Firefox as well https://github.com/ajayyy/SponsorBlock/wiki/Testing-a-Pull-Request#installing
@ajayyy
Getting a load of errors unrelated to this issue. That build seems to be broken out right.
After loading the build:
I get the can't convert undefined to object
when opening the sponsorblock window from the extension in the top right.
Also experiencing this issue, and can also confirm that above debug build does not work with Firefox.
Sorry about that, I have updated the builds in that comment. It was pointing to my debug server and not the main one
I was able to reproduce it with the debug build, I don't know if it matters, but I middle mouse clicked multiple videos from https://www.youtube.com/feed/subscriptions and let them load in the background, then went through them and found the first one with a sponsor segment (https://www.youtube.com/watch?v=o69WALtFpI0) and watched (at 2x speed, maybe important?) through until the sponsor section. The sponsor section was properly marked on the timeline, but wasn't skipped once it entered the section. Manually opening the SB panel and refreshing the segments made SB properly skip it. Here's the log, there is also a CSP violation error that seem to stem from SB so I included that as well.
@hakkin do you use videospeed extension?
For what it's worth this happens to me too and I watch at 2x speed with the extension tweaks for YouTube
On Sat, 19 Aug 2023, 2:31 pm Ajay Ramachandran, @.***> wrote:
Sorry about that, I have updated the builds in that comment
— Reply to this email directly, view it on GitHub https://github.com/ajayyy/SponsorBlock/issues/1820#issuecomment-1684944402, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFLTC55VL3N2F5EGOAP4NDXWC5Z3ANCNFSM6AAAAAA3HNJ3CA . You are receiving this because you commented.Message ID: @.***>
@Hakkin do you use videospeed extension?
The YouTube extensions I have are "Enhancer for YouTube", "HyperChat", "ytcFilter" and "YouTube Livestreams Theater Mode". Enhancer for YouTube offers higher than 2x playback, but I rarely go above 2x, and I change the speed using YouTube's keyboard shortcut (Shift+.) rather than Enhancer's (Ctrl+Mousewheel).
I also just reproduced this with all those extensions disabled though, only SponsorBlock + YouTube's built-in 2x playback.
@Hakkin thanks for being so specific on when the skip didn't happen in the logs!
Could you try this again with this build with even more logging?
@ajayyy Here are the logs, from https://www.youtube.com/watch?v=3rjnRJlJyAY
It definitely seems to have something to do with the playback speed. I was testing with this video: https://www.youtube.com/watch?v=TCJrC9KRnrQ Playing at 1x playback rate, SB skips the ad at the beginning 10/10 times, but at 2x speed it only skips it maybe 1/10 times. More specifically, it seems to have something to do with changing the playback speed during playback. If the playback speed is changed while the video is paused, then unpaused, or if you change the video speed then either seek or pause/unpause the video, the skipping will work correctly, even at 2x. It's only when you adjust the playback speed while the video is playing and then continue watching without any further interactions (pausing, seeking) that skipping seems to break. For example, if you start playing the video at 1x, then hit Shift+. x4 to increase the speed to 2x, and continue watching, the skipping will be broken, but if you refresh, then pause the video, hit Shift+. x4, then unpause the video, the skipping will work fine. Seeking in the video also seems to "reset" the skipping and fixes it as well. So a current work around is to change the playback rate to 2x, then either pause and unpause, or seek back 5s (left arrow key). Both of these seem to reliably fix it for me.
I regularly encounter this, I also watch every video sped-up and change playback rates live, usually with Video Speed Controller (Chrome) keyboard shortcuts.
Can you try out this build and see if you can reproduce the issue? I added code to check every 2 seconds if the playback rate has changed incase for some reason the playbackChanged browser event isn't being sent.
If it still fails, can you send the logs again?
EDIT: Actually I need to change one thing sorry will post another comment
Okay, fixed the issue in the build from last comment, please try these builds
Testing with a few videos, that build seems to have fixed it for me. Skipping works at 2x and even 3x via Enhancer for YouTube.
Maybe you've already caught it, but I think I found the issue.
The code at https://github.com/ajayyy/SponsorBlock/blob/64ece9cb733864924b1457e4a181662134b00a51/src/content.ts#L937 seems incorrect, it should just be getVideo().addEventListener('ratechange', rateChangeListener)
rather than () => rateChangeListener
. When the event is triggered, it's currently calling (() => rateChangeListener)(event)
, which just returns the rateChangeListener
function rather than calling it.
It seems this was introduced in this commit which converted rateChangeListener
from an anonymous arrow function to a named variable, but forgot to remove the arrow function declaration in the addEventListener
call.
oh wow! good catch that makes sense! I'll look to see if I can get eslint to warn me about these things
@ajayyy im having this same issue still on firefox
Also still having this issue on the latest Firefox build.
I have the same issue on Vivaldi, It's only working if I play the same video second times (play → stop, play → stop), but, if I swich to another video, the previous video will not skipping when I play it (need click stop → play again to make it work).
I have this issue on brave browser on macos, thanks
having this issue right now.
Started having this issue on Firefox after updating to 132.0.
Fully up-to-date. Youtube settings: stable audio:off, ambient mode:off, subtitles:off, playback:normal, sleep timer:off, quality:Auto(1080p60).
I turned off all other add-ons and restarted Firefox so SponsorBlock is the only running add-on. It loads the blocks and shows them on the progress bar, it just doesn't skip them until I reload the page. It always fails to skip on the first load. Rewinding doesn't help, only reloading.
Potential snag: I open every video by right clicking -> open link in new tab. I'll open several videos from the main or sub page this way, then watch them one at a time, closing each tab afterwards. This means they only fully load once I actually switch to the tab. The page, script, or both may not be loading as expected compared to clicking through.
I have not tested just clicking through to a video because I'll never actually do that when using youtube... not since they added the miniplayer that continues playing the video after clicking back in the browser. Latter pages should never affect how a former page is presented when returning to it.
You would probably be better off opening a new issue, whatever you're experiencing is most likely unrelated to this issue, which has already been fixed.
What makes it seem like this issue has been fixed? I don’t use the mentioned “enhancer” and still have the issue as of last night.Thanks On Nov 17, 2024, at 1:03 PM, Hakkin Lain @.***> wrote: You would probably be better off opening a new issue, whatever you're experiencing is most likely unrelated to this issue, which has already been fixed.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>
I've been noticing that SponsorBlock isn't skipping sponsored segments. When I rewind and play the video again, the sponsored segments are skipped as normal. I can't see any errors or other logs in the console. Let me know if I need to attach any logs or something similar.
P.S.: I'm also running Enhancer for Youtube, uBlock Origin and Return Youtube Dislike extensions.