ajayyy / SponsorBlock

Skip YouTube video sponsors (browser extension)
https://sponsor.ajay.app
GNU General Public License v3.0
10.21k stars 323 forks source link

Video rotates from landscape to portrait Firefox Android #1993

Open caeci11ius opened 7 months ago

caeci11ius commented 7 months ago

This was working really nicely on the Android version of Firefox until about a week ago. Since then, it's been causing the video player to rotate back to portrait periodically during playback (sometimes seems associated with skips, but not always). Happens within a few minutes regardless.

Phone is configured with automatic rotation disabled. Commencing in portrait, Firefox will rotate to landscape when fullscreen playback is selected. After a few minutes of playback with sponsorblock running, the video will rotate back to portrait. Skipping forward/back using double tap restores landscape orientation, as does exiting and re-entering fullscreen. Disabling plugin fixes the issue.

Plugin version 5.5.9 Firefox version 124.1.0 Pixel 7 Pro 5 March 2024 firmware

Wolfdv1 commented 7 months ago

+1 came to report the exact same behaviour, as well as doing so randomly and during skips, seems to sometimes react to touch input to the screen

Version Info:

{
"debug": {
    "userAgent": "Mozilla/5.0 (Android 13; Mobile; rv:124.0) Gecko/124.0 Firefox/124.0",
    "platform": "Linux armv81",
    "language": "en-GB",
    "extensionVersion": "5.5.9"
},
"config": {
    "allowScrollingToEdit": true,
    "autoSkipOnMusicVideosUpdate": true,
    "categoryPillUpdate": true,
    "chapterCategoryAdded": true,
    "dontShowNotice": false,
    "hideUploadButtonPlayerControls": true,
    "invidiousInstances": 33,
    "isVip": false,
    "minutesSaved": 953.4461867000002,
    "permissions": {
        "sponsor": true,
        "selfpromo": true,
        "exclusive_access": true,
        "interaction": true,
        "intro": true,
        "outro": true,
        "preview": true,
        "music_offtopic": true,
        "filler": true,
        "poi_highlight": true,
        "chapter": false
    },
    "showPopupDonationCount": 2,
    "showZoomToFillError2": false,
    "skipCount": 1201,
    "defaultCategory": "chooseACategory",
    "renderSegmentsAsChapters": false,
    "whitelistedChannels": 0,
    "forceChannelCheck": false,
    "sponsorTimesContributed": 0,
    "submissionCountSinceCategories": 0,
    "showTimeWithSkips": true,
    "disableSkipping": false,
    "muteSegments": true,
    "fullVideoSegments": true,
    "fullVideoLabelsOnThumbnails": true,
    "manualSkipOnFullVideo": false,
    "trackViewCount": true,
    "trackViewCountInPrivate": true,
    "trackDownvotes": true,
    "trackDownvotesInPrivate": false,
    "noticeVisibilityMode": 3,
    "hideVideoPlayerControls": false,
    "hideInfoButtonPlayerControls": false,
    "hideDeleteButtonPlayerControls": false,
    "hideSkipButtonPlayerControls": false,
    "hideDiscordLaunches": 0,
    "hideDiscordLink": false,
    "supportInvidious": false,
    "serverAddress": "Default server address",
    "minDuration": 0,
    "skipNoticeDuration": 4,
    "audioNotificationOnSkip": false,
    "checkForUnlistedVideos": false,
    "testingServer": false,
    "refetchWhenNotFound": true,
    "ytInfoPermissionGranted": false,
    "allowExpirements": true,
    "showDonationLink": true,
    "showUpsells": true,
    "showNewFeaturePopups": true,
    "donateClicked": 0,
    "autoHideInfoButton": true,
    "autoSkipOnMusicVideos": false,
    "scrollToEditTimeUpdate": false,
    "showChapterInfoMessage": true,
    "darkMode": true,
    "showCategoryGuidelines": true,
    "showCategoryWithoutPermission": false,
    "showSegmentNameInChapterBar": true,
    "useVirtualTime": true,
    "showSegmentFailedToFetchWarning": true,
    "deArrowInstalled": false,
    "showDeArrowPromotion": true,
    "showDeArrowInSettings": true,
    "shownDeArrowPromotion": false,
    "cleanPopup": false,
    "categoryPillColors": {},
    "skipKeybind": {
        "key": "Enter"
    },
    "skipToHighlightKeybind": {
        "key": "Enter",
        "ctrl": true
    },
    "startSponsorKeybind": {
        "key": ";"
    },
    "submitKeybind": {
        "key": "'"
    },
    "actuallySubmitKeybind": {
        "key": "'",
        "ctrl": true
    },
    "previewKeybind": {
        "key": ";",
        "ctrl": true
    },
    "nextChapterKeybind": {
        "key": "ArrowRight",
        "ctrl": true
    },
    "previousChapterKeybind": {
        "key": "ArrowLeft",
        "ctrl": true
    },
    "closeSkipNoticeKeybind": {
        "key": "Backspace"
    },
    "categorySelections": [
        {
            "name": "sponsor",
            "option": 2
        },
        {
            "name": "poi_highlight",
            "option": 1
        },
        {
            "name": "exclusive_access",
            "option": 0
        },
        {
            "name": "chapter",
            "option": 0
        }
    ],
    "payments": {
        "licenseKey": null,
        "lastCheck": 0,
        "lastFreeCheck": 0,
        "freeAccess": false,
        "chaptersAllowed": false
    },
    "colorPalette": {
        "red": "#780303",
        "white": "#ffffff",
        "locked": "#ffc83d"
    },
    "barTypes": {
        "preview-chooseACategory": {
            "color": "#ffffff",
            "opacity": "0.7"
        },
        "sponsor": {
            "color": "#00d400",
            "opacity": "0.7"
        },
        "preview-sponsor": {
            "color": "#007800",
            "opacity": "0.7"
        },
        "selfpromo": {
            "color": "#ffff00",
            "opacity": "0.7"
        },
        "preview-selfpromo": {
            "color": "#bfbf35",
            "opacity": "0.7"
        },
        "exclusive_access": {
            "color": "#008a5c",
            "opacity": "0.7"
        },
        "interaction": {
            "color": "#cc00ff",
            "opacity": "0.7"
        },
        "preview-interaction": {
            "color": "#6c0087",
            "opacity": "0.7"
        },
        "intro": {
            "color": "#00ffff",
            "opacity": "0.7"
        },
        "preview-intro": {
            "color": "#008080",
            "opacity": "0.7"
        },
        "outro": {
            "color": "#0202ed",
            "opacity": "0.7"
        },
        "preview-outro": {
            "color": "#000070",
            "opacity": "0.7"
        },
        "preview": {
            "color": "#008fd6",
            "opacity": "0.7"
        },
        "preview-preview": {
            "color": "#005799",
            "opacity": "0.7"
        },
        "music_offtopic": {
            "color": "#ff9900",
            "opacity": "0.7"
        },
        "preview-music_offtopic": {
            "color": "#a6634a",
            "opacity": "0.7"
        },
        "poi_highlight": {
            "color": "#ff1684",
            "opacity": "0.7"
        },
        "preview-poi_highlight": {
            "color": "#9b044c",
            "opacity": "0.7"
        },
        "filler": {
            "color": "#7300FF",
            "opacity": "0.9"
        },
        "preview-filler": {
            "color": "#2E0066",
            "opacity": "0.7"
        }
    }
}
}
Bucketsmith commented 5 months ago

I guess this is the problem I keep having on Android Firefox, as well.

Wolfdv1 commented 4 months ago

Update:

Based on the time that I think this bug started happening, I found the firefox releases around that time and after trying v122 of Firefox android with sponsor block, the issue is not present. Must've been a change in Firefox Android 122.0.1+ that is causing this

In case anyone wants to rush using an outdated version to continue using sponsor block without this issue: https://github.com/mozilla-mobile/firefox-android/releases/tag/fenix-v122.0.1 (you could also use a beta of 122 instead to have a separate app for just streaming videos with sponsor block)

whitequark commented 1 month ago

I'm also experiencing this issue.

caeci11ius commented 1 month ago

As a semi-workaround, this still happens if you enable auto-rotation, but you won't notice it mostly. The exception is if your device is flat on a table or something where the orientation isn't clear (in which case picking it up will fix).

Annoying, but mostly does the job if you can handle having autorotation switched on (I found I mostly can, though can cause the odd issue using phone in bed). Still be nice if it was fixed though given it used to just work properly...might be why few people seem to have noticed though.

And while I'm here: still happening in Firefox 130.

Wolfdv1 commented 1 month ago

Also, as it was a update from Firefox that is causing this, you can at your own discretion use an older version. https://github.com/mozilla-mobile/firefox-android/releases/tag/fenix-v122.0.1 for example does not have this issue

On Sat, 14 Sept 2024, 23:44 caeci11ius, @.***> wrote:

As a semi-workaround, this still happens if you enable auto-rotation, but you won't notice it mostly. The exception is if your device is flat on a table or something where the orientation isn't clear (in which case picking it up will fix).

Annoying, but mostly does the job if you can handle having autorotation switched on (I found I mostly can, though can cause the odd issue using phone in bed). Still be nice if it was fixed though given it used to just work properly...might be why few people seem to have noticed though.

— Reply to this email directly, view it on GitHub https://github.com/ajayyy/SponsorBlock/issues/1993#issuecomment-2351168111, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJVVQUBXSGRPZUOYMTTSYTZWSU4BAVCNFSM6AAAAABFRAFDO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJRGE3DQMJRGE . You are receiving this because you commented.Message ID: @.***>

Bucketsmith commented 1 month ago

Tap forward or backward to move 10s, then the other way to come back where you left. It will revert back to fullscreen landscape.

Sidenote, outdated versions run the risk of unpatched security flaws, it is not recommended to use them.

whitequark commented 1 month ago

I would have to destroy my Firefox profile to downgrade, since Android no longer allows downgrading applications over an old installation :(

Wolfdv1 commented 1 month ago

This is true, I personally however have multiple different versions of Firefox on my phone for different uses- Firefox beta, 'main' old version (security risks associated acknowledged and accounted for (gotta love Open Source)) and also Firefox Klar/Focus. Having a Mozilla account to sync everything fixes most issues, tho some parts of configuration do need to be redone- I've attempted to have a look to see the diff in Firefox builds that broke this extension, but to no success as of yet.

If I were to guess it could either be an issue with Firefox itself that was fixed, but the extension had an underlying reliance on- if I find the cause I'll open a PR either here, or on the FF pages

On Mon, 16 Sept 2024, 10:43 Catherine, @.***> wrote:

I would have to destroy my Firefox profile to downgrade, since Android no longer allows downgrading applications over an old installation :(

— Reply to this email directly, view it on GitHub https://github.com/ajayyy/SponsorBlock/issues/1993#issuecomment-2352324985, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJVVQRIBBTEALDWQ2CLWJTZW2K27AVCNFSM6AAAAABFRAFDO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJSGMZDIOJYGU . You are receiving this because you commented.Message ID: @.***>

whitequark commented 1 month ago

Thanks for looking into the issue! Much appreciated.