Skipping inner-segment skips overlapping larger segment on autoskip

ajayyy / SponsorBlock

Skip YouTube video sponsors (browser extension)

https://sponsor.ajay.app

GNU General Public License v3.0

10.16k stars 323 forks source link

Skipping inner-segment skips overlapping larger segment on autoskip #686

Open mchangrh opened 3 years ago

mchangrh commented 3 years ago

Video Example:

https://www.youtube.com/watch?v=709ydk3PorM Segments:

Intermission 0:00 - 0:47
Interaction Reminder 0:27 - 0:29

When manually scrubbing through the intermission, once SponsorBlock hits the Interaction reminder, instead of skipping the interaction reminder it skips to the end of the intermission.

Both intermission and interaction reminder are set to auto skip

"debug": {
        "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.82 Safari/537.36",
        "platform": "Win32",
        "language": "en-CA",
        "extensionVersion": "2.0.12.4"
    },

mchangrh commented 3 years ago

Replicated on beta 2.0.13

Replicated with two segments of the same type and of different type.

ajayyy commented 3 years ago

I guess the logic would be to ignore segments which start before the start of the segment that was just previously skipped.

mchangrh commented 3 years ago

Does manually scrolling into a segment disable the segment or just bypass autoskip for that segment?

ajayyy commented 3 years ago

It bypasses autoskip, but right now there is code to include segments that the video player is currently in right after skipping a segment. This is to support skipping into the middle of a segment that started a little bit before the end of the previous one.

mchangrh commented 3 years ago

Would it be more reasonable to include a check for inner segments or to calculate which point to skip to separately