search

ajayyy / SponsorBlock

Skip YouTube video sponsors (browser extension)
https://sponsor.ajay.app
GNU General Public License v3.0
10.21k stars 323 forks source link

Options button on in-page popup doesn't work after alert #750

Open ajayyy opened 3 years ago

ajayyy commented 3 years ago

https://github.com/ajayyy/SponsorBlock/issues/741#issuecomment-844609129

https://github.com/ajayyy/SponsorBlock/issues/741#issuecomment-844628036

fluffy-critter commented 3 years ago

When I inspect the element I just see a <button> element with no attached script or event listener. Clicking on it has no effect, and no new messages appear in the console. Other buttons in the addon work (such as editing my username).

image image
fluffy-critter commented 3 years ago

Reinstalling the extension fixed the issue.

ajayyy commented 3 years ago

Sorry, I meant on the options page itself.

For the next person, click on the options button, and then open inspect element, go to console and screenshot the error there.

fluffy-critter commented 3 years ago

I was unable to get to the options page at all.

ajayyy commented 3 years ago

Oh, you mean the button itself doesn't work, I see. That was probably just a side effect of the popup. For future, you can try using the extension icon in the browser toolbar instead to get to it.

fluffy-critter commented 3 years ago

Ah, yeah, I have no idea if that bit was functional or not. I keep the extension icon hidden since 99% of the time it just takes up space and the remaining 1% of the time it's redundant with the button on the video overlay.