search

ajbc / trellis

Other
9 stars 3 forks source link

no leaf nodes in root #30

Open ajbc opened 7 years ago

ajbc commented 7 years ago

Do we want to have leaf nodes able to exist in the root node without being assigned to a cluster? My gut is no. @bstewart @shiraito, confirm?

screen shot 2017-09-04 at 6 19 34 pm

@AFriendlyRobot want to tackle this too?

ajbc commented 7 years ago

@gwgundersen want to add guidance?

bstewart commented 7 years ago

I think no because at the moment it is a difference without a distinction. You can set it up however you want: i.e. they are in their own clusters of size one as in the "senate, lieberman, committee" example above or they are simply members of the larger cluster as in "obama, chicago, rezko" etc. To keep it consistent with what is done deeper in the hierarchy I'd lean towards the latter- but I'm fine as long as it is consistent.

gwgundersen commented 7 years ago

@AFriendlyRobot, the logic for whether or not a move can go forward is in selectNode, which delegates to moveOrMerge as needed. When the user tries to move a leaf node into the root node, it sounds like we want to either (1) stop that from happening, (2) create a new group even if the user didn't also hold down shift, or (3) just let them. If the second option, you can call moveOrMerge with makeNewGroup set to true.

AFriendlyRobot commented 6 years ago

Revisiting this, the current build allows leaves as direct children of the root. This is similar behavior to leaves as siblings of clusters further in the root, so I'm of the opinion that this does not need to change.