search

ajboni / airwindows-cheatsheet-v1

Cheatsheet for airwindows plugins.
https://airwindowscheatsheet.aboni.dev
GNU General Public License v3.0
16 stars 3 forks source link

I added a dark theme button for the website #24

Closed Young-Tran closed 2 years ago

ajboni commented 2 years ago

Thanks for the PR! unfortunately I don't think this is working as expected, see the screenshot below: image

the issues I see are:

  1. The toggle button should be in the nav
  2. The whole background should be dark and the letters opposite (see for example: https://coliff.github.io/dark-mode-switch/)

Thanks!

Young-Tran commented 2 years ago

I will fix it sorry its my first time working with svelte

On Fri, Sep 24, 2021 at 6:08 PM Alexis Boni @.***> wrote:

Thanks for the PR! unfortunately I don't think this is working as expected, see the screenshot below: [image: image] https://user-images.githubusercontent.com/12578313/134752706-6fb88c04-d2f5-42c3-813c-9b20925108f8.png

the issues I see are:

  1. The toggle button should be in the nav
  2. The whole background should be dark and the letters opposite (see for example: https://coliff.github.io/dark-mode-switch/)

Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ajboni/airwindows-cheatsheet/pull/24#issuecomment-926987175, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGHC6FRXYTSQMHGZX4AU2LDUDUOHVANCNFSM5EW5YAYA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.