search

ajbrown / angular-loggly-logger

An AngularJS module which sends your $log message to loggly, and provides a service for manually sending messages to loggly.
MIT License
32 stars 49 forks source link

Using http #33

Closed varshneyjayant closed 8 years ago

varshneyjayant commented 8 years ago
  1. Removed Image src request to send events to Loggly
  2. Added $http.post to send requests to Loggly
ajbrown commented 8 years ago

@psquickitjayant The img.src was originally used to get around CORS issues (if I recall correctly). Is this now working correctly with the $http.post request?

ajbrown commented 8 years ago

It looks like you're removing a lot of the tests. If the $http.post does in fact work, we'll want to update the tests as well.

varshneyjayant commented 8 years ago

@ajbrown yes, Loggly has deployed CORS header on their servers. We will be adding test cases soon, you can also help in doing that.

varshneyjayant commented 8 years ago

@ajbrown We have updates test cases. Please review.

varshneyjayant commented 8 years ago

@ajbrown please check if this PR can be merged. We have added all the required test cases.

ajbrown commented 8 years ago

@psquickitjayant Thanks! I'll go ahead and cut this into a new release now as well.

ajbrown commented 8 years ago

@psquickitjayant Sorry false alarm. I just noticed this is targetting master. Can you re-open targetting develop?

varshneyjayant commented 8 years ago

sure, thanks!

varshneyjayant commented 8 years ago

I can see new merges after the code update. I will rebase the code and update it and submit the new pull request.