search

ajbrown / angular-loggly-logger

An AngularJS module which sends your $log message to loggly, and provides a service for manually sending messages to loggly.
MIT License
32 stars 49 forks source link

Npm install fails unless bower is already installed #39

Closed SamPlacette closed 8 years ago

SamPlacette commented 8 years ago

This broke our build the other night. I can reproduce fairly easily.

First, make sure bower is not installed locally or globally.

This fails (see attached debug log):

mkdir loggly_test
cd loggly_test
npm init --yes
npm install angular-loggly-logger

It works if I do it like this:

mkdir loggly_test
cd loggly_test
npm init --yes
npm install bower
npm install angular-loggly-logger

I believe the fix is simply moving bower into the "dependencies" property of package.json, so it is marked as required for installation. I want to open this issue before working on a fix.

npm-debug.log.txt

ajbrown commented 8 years ago

@SamPlacette To fix this, I went ahead and removed bower as a dependency altogether. It was only needed for the demo app and to get the angular dependency. The angular dependency is now pulled in via package.json, and that version is referenced in the demo app.

I'll cut a release for this shortly.