ajcrowe / puppet-supervisord

Puppet Module to install and configure applications under supervisord
MIT License
37 stars 104 forks source link

Notify supervisord on config directory change. #125

Open skrivy opened 5 years ago

skrivy commented 5 years ago

Problematic situation:

class { 'supervisord':
    ...
    config_include       => '/etc/supervisor/conf.d',
    config_include_purge => true,
    ...
}

If we remove any supervisord::program block with this configuration, it's .conf file gets deleted, but supervisord process is not reloaded and removed program remains running.

This patch reconfigures supervisord on the conf directory content change.

quanghiem commented 5 years ago

By notifying supervisord::service, puppet will restart the supervisord service on any config change. This should notify supervisord::reload instead so that puppet issues a supervisorctl reread and update instead to avoid any downtime.

skrivy commented 5 years ago

@quanghiem Feel free to update the PR.

quanghiem commented 5 years ago

@skrivy I don't think people can add commits to your PR.

ajcrowe commented 5 years ago

Sorry for the slow reply guys

If @skrivy wants to close this and @quanghiem you want to propose a new PR based on this.