search

ajcrowe / puppet-supervisord

Puppet Module to install and configure applications under supervisord
MIT License
37 stars 104 forks source link

No option to configure multiple drectories in the [include] section. #15

Closed hasc closed 10 years ago

hasc commented 10 years ago

Hi,

first thanks for sharing this module.

I am have the problem that it is not possible to configure multiple directories in the [include] section of the supervisord.conf file. According to the configuration reference of supervisord this would be possible.

I wrote an augeas script to place whatever value i want but the module realizes this and overwrites it again. Which is somehow good and sad.

Making the configuration more flexible here, would be a great thing.

Thanks Hannes

ajcrowe commented 10 years ago

This is a tricky one, given that most people will be configuring all aspects of supervisord through the module having multiple directories would only make configuration more complex.

I thought about having the config_include param as an array but this means I would need to pick one of those as the location for all the configs. I think I will make the config_include param a simple string rather than a absolute path so you can customise it with you own space seperated paths.

Let me know if this works for you

ajcrowe commented 10 years ago

Actually this will break things as I rely on this for config file paths in other resources, I will have a think about the best approach.

hasc commented 10 years ago

Hey,

Thanks for the quick response. I understand what you mean and that it conflicts with how you use this parameter.

I played a bit with it and found a simple workaround. I added a parameter $file to the class definition and added it also to the template file. With this everything works as before.

Let me know if you need more details. I am currently on the road...

Best Hannes

ajcrowe commented 10 years ago

I've committed code to add this feature, see f863a94. You can now specific an array of include paths with $config_dirs. If this is not specified ${config_include}/*conf will be used, so make sure it includes this.

This is a bit of a work around and the name could be better but I want to avoid breaking changes for existing users of the module which this does.

Give it a try and let me know if this work, I'll look to get this out in a release shortly.

hasc commented 10 years ago

Hi,

i'll give it a try as soon as possible and write back.

Thanks! Hannes

hasc commented 10 years ago

Hi,

i just gave it a try and it works perfectly. Thanks, a lot for your help. Looking forward to see it in the next release.

Regards Hannes

ajcrowe commented 10 years ago

Great, I'll push out a release shortly.

Thanks for the input.