ajdamico / lodown

locally download and prepare publicly-available microdata
GNU General Public License v3.0
97 stars 47 forks source link

please cran check before you push a commit #50

Closed ajdamico closed 7 years ago

ajdamico commented 7 years ago
* checking loading without being on the library search path ... OK
* checking dependencies in R code ... NOTE
There are ::: calls to the package's namespace in its code. A package
  almost never needs to use ::: for its own objects:
  'recursive_ftp_scrape'
* checking S3 generic/method consistency ... OK
* checking replacement functions ... OK
* checking foreign function calls ... OK
* checking R code for possible problems ... NOTE
get_catalog_mtps: no visible binding for global variable 'URLdecode'
lodown_mtps: no visible global function definition for 'read.csv2'
Undefined global functions or variables:
  URLdecode read.csv2
Consider adding
  importFrom("utils", "URLdecode", "read.csv2")
to your NAMESPACE file.
* checking Rd files ... OK
* checking Rd metadata ... OK
* checking Rd line widths ... OK
* checking Rd cross-references ... OK
* checking for missing documentation entries ... OK
* checking for code/documentation mismatches ... OK
* checking Rd \usage sections ... OK
* checking Rd contents ... OK
* checking for unstated dependencies in examples ... OK
* checking examples ... OK
* DONE
Status: 2 NOTEs

See
  'C:/Users/anthonyd/Documents/GitHub/lodown.Rcheck/00check.log'
for details.

checking dependencies in R code ... NOTE
There are ::: calls to the package's namespace in its code. A package
  almost never needs to use ::: for its own objects:
  'recursive_ftp_scrape'

checking R code for possible problems ... NOTE
get_catalog_mtps: no visible binding for global variable 'URLdecode'
lodown_mtps: no visible global function definition for 'read.csv2'
Undefined global functions or variables:
  URLdecode read.csv2
Consider adding
  importFrom("utils", "URLdecode", "read.csv2")
to your NAMESPACE file.
R CMD check results
0 errors | 0 warnings | 2 notes

R CMD check succeeded
guilhermejacob commented 7 years ago

That solved it. Right?

ajdamico commented 7 years ago

if rstudio check gives you this, you are good, thanks

R CMD check results
0 errors | 0 warnings | 0 notes

R CMD check succeeded