Tornado 3.0

[wsantos]

Not compatible yet.

[ajdavis]

Do you have an example that demonstrates the incompatibility?

[wsantos]

Sure, im working in this "port", now the options is not a dict instance so the code below won't work.

if not opts[required].value():

this must be something like

if not getattr(opts, required, None):

another issue is, what are moto-blog duplicating options data in settings ?

        ...
        tz=pytz.timezone(opts.timezone),
        gzip=True,
        **{k: v.value() for k, v in opts.items()}
    )

maybe would be good change this behaviour now we can access options easly

from tornado.options import options

print options.MY_OPTION

regards.

[ajdavis]

OK, good suggestions. If you'd like to submit a patch I'd be happy to look at it.

On Wed, Apr 3, 2013 at 10:32 AM, Waldecir Loureiro dos Santos Filho < notifications@github.com> wrote:

Sure, im working to in "port", now the options is not a dict instance so the code below won't work.

if not opts[required].value():

this must be something like

if not getattr(opts, required, None):

another isso is, what are moto-blog duplicating options data in settings ?

    ...
    tz=pytz.timezone(opts.timezone),
    gzip=True,
    **{k: v.value() for k, v in opts.items()}
)

maybe would be good change this behaviour now we can access options easly

from tornado.options import options print options.MY_OPTION

regards.

— Reply to this email directly or view it on GitHubhttps://github.com/ajdavis/motor-blog/issues/14#issuecomment-15840055 .

[wsantos]

I think we need more work in get_setting, and in the part of settings/options separation, but i can get a big part woring, i cant find any error, i will run a blog with motor-blog so i want to keepit update, if needd i will send more PRs.

regards.

[ajdavis]

Thanks for this, sorry it took so long to merge.