search

ajdavis / motor-blog

Blog based on Tornado, MongoDB, and Motor. To be used with MarsEdit.
148 stars 40 forks source link

Multiple self.settings['db'] calls instead of "MotorBlogHandler" self.db #5

Closed jchassoul closed 11 years ago

jchassoul commented 11 years ago

Hi!,

I don't know if this is really an issue (don't affect anything really...) but you have what seems like a base class: MotorBlogHandler in ../motor_blog/web/handlers.py line 39 I found that you have: self.db = self.settings['db'] but you don't use self.db on any of the classes that inherit MotorBlogHandler, not even inside MotorBlogHandler on line 71 you're calling again self.settings

Why are you calling self.settings again instead of self.db?

BTW, I really enjoy reading your code, thanks for sharing your projects with the world (=

ajdavis commented 11 years ago

Thanks @jchassoul, good catch. =)