search

ajdawson / eofs

EOF analysis in Python
http://ajdawson.github.io/eofs/
GNU General Public License v3.0
199 stars 60 forks source link

Bug fix for conflict between `dask` array and `np.where` #144

Closed lee1043 closed 8 months ago

lee1043 commented 8 months ago

When dask import, use dask.array.where instead of np.where. This should resolve #143 and #122. The solution was originally suggested by @lfery and I extended it to consider the has_dask indicator (True when dask imported, and False for the opposite).

lee1043 commented 8 months ago

@ajdawson I wonder if this fix could be merged to the main and you could release updated version, e.g., v1.4.1. If so, that would be a huge help for my workflow. Because otherwise, I have to consider hosting the capability of eofs in my package directly instead of leveraging on your package that has been considered as one of major dependencies of my package.