Address numpy DeprecationWarnings

ajdawson / eofs

EOF analysis in Python

http://ajdawson.github.io/eofs/

GNU General Public License v3.0

199 stars 60 forks source link

Address numpy DeprecationWarnings #148

Open Zeitsperre opened 7 months ago

Zeitsperre commented 7 months ago

Hi there,

I've been working to reduce warnings in a downstream project and figured I could send a PR your way to address some messages coming from here.

Changes

Added the packaging library (provides a version-parsing replacement for the deprecated distutils, endorsed by PyPA)
Added a backwards-compatible numpy.{prod|product}, which can be removed when eofs drops Python3.8 support.
Replaced deprecated np.NaN artifacts with np.nan.

All the best!

Zeitsperre commented 2 months ago

@ajdawson Hi, I was just wondering if there's anything else I can do to help this PR along. Thanks!

bbuzz31 commented 1 month ago

@Zeitsperre on line 206 in standard.py you need to change np.NaN to np.nan for the newest numpy version. for such a small change I'm too lazy to issue a PR to your branch (sorry!)

Zeitsperre commented 1 month ago

@bbuzz31 Not sure if I understand.

Do you mean to say that you'll be dropping NumPy v1.x support, so the only changes needed are for the new np.nan? np.product still needs to be replaced with np.prod for NumPy v2.0.

Edit: Ah, I understand! My bad! Will modify.

bbuzz31 commented 1 month ago

Thanks!