search

ajdawson / windspharm

A Python library for spherical harmonic computations on vector winds.
http://ajdawson.github.io/windspharm
MIT License
82 stars 38 forks source link

Fix for Rossby wave source examples #38

Closed DamienIrving closed 10 years ago

DamienIrving commented 10 years ago

I noticed a small error in your calculation for the Rossby wave source whereby this, S = -eta * div - uchi * etax + vchi * etay should actually be S = -eta * div - (uchi * etax + vchi * etay)

When viewing plots of S the error isn't really noticeable by eye. It was only when I broke down the calculation into the S1 = -eta * div and S2 = - (uchi * etax + vchi * etay) components as Shimizu & de Albuquerque Cavalcanti (2011) does that I noticed the error in the S2 component (i.e. I was trying to reproduce Figure 6 of that paper using your windspharm example).

ajdawson commented 10 years ago

Nice catch @DamienIrving thanks. I'll try and update the live online documentation for v1.3.1 too.

ajdawson commented 10 years ago

I've updated the live documentation now too so this mistake shouldn't trip anyone up. Thanks again @DamienIrving.