Support Form hangs on submission

[ajdruff]

When submitting the support form, it hangs and doesn't complete submission

[ajdruff]

cause: \ Form was never updated to use the most recent response model. fix:** added $this->sendFormResponse() to hookFormActionAjaxContactSupport() found in Forms.php / Nomstock_Com_Modules_Forms extends Nomstock_Com_Base_v1c2_Plugin_Module

troubleshooting:

• ran firebug:
• check console: TypeError: responseObject is null
• check XHR post: looks ok, submitted form values to handler
• identify form action: look at post value of 'action' , which is nomstock_com_contact_support. Take the text after nomstockcom, and get 'contact_support' . search for this text in code, and find $this->addFormActionAjax( 'contact_support' ); in Forms.php. This maps the ajax action to the following method ( by naming convention ) : hookFormActionAjaxContactSupport.
• setup a debug method in DebugConfig.php and add hookFormActionAjaxContactSupport as a filter.
• submit again, with same results and no debug output.
• to confirm that the hookFormActionAjaxContactSupport is being fired by ajax, intentionally break the ajax by renaming temporarily the hookFormActionAjaxContactSupport method. submit again, and get error. this is good, it means that the hookFormActionAjaxContactSupport is being fired. *next, added a simple ' echo 'great'' to the method and exited, and it worked without error. removed the temporary code. this all points to $this->_SubmitForm method as the culprit.
• next, look at the _SubmitForm. add the following lines to your debug method:

        $this->debug()->setMethodFilter( '.*_SubmitForm.*', true );
          $this->debug()->setMethodFilter( 'hookFormActionAjaxContactSupport', true );

• finally , we get some debug output from the form submission. it tells us that the submission is fine, all value were inserted into the database successfully. i check the database simpli_forms and find that the values were added correctly.
• so : everything is working except the javascript displaying the response. I reviewed the _SubmitForm code again, and realized it looks like its using the new methods in Forms.php , which means (as I recall) the responses are being handled differently. Went back and reviewed the working domain submission form and found that it was using the $this->sendFormResponse()method, whereas the support form is not. I added it to hookFormActionAjaxContactSupport();
• retried submission, this time everything worked in debug mode. now turned off debug with $this->debugSupportForm(false); and tried again.
• Everything is working! Fix was just to add $this->sendFormResponse() to the last part of the code after the handler was done.