ajeetdsouza
commented
2 years ago Hey, apologies for the delayed response. joshuto looks great!
zoxide does a file read upon query and a file write upon add. Are you planning on calling the library function in your main thread? If not, it may not matter whether you use the library or spawn a child process. Plus, you can batch calls to zoxide add (it takes multiple paths), making it still faster.
I'm not very convinced about turning zoxide into a library for the sake of one application. I resonate with the creator of fzf here (https://github.com/junegunn/fzf/issues/2097):
- It's cumbersome to maintain a stable API
- The CLI is quite useable, even as a child process
Most importantly, it's hard to justify the effort of building a library unless enough people are using it. I'm seeing a lot of upvotes on this issue, so if anybody plans to use zoxide as a library in another project, please do post here!
It would be awesome to integrate zoxide in other rust tools especially file managers like joshuto. Would it be possible to make a zoxide library similar to the way skim is both a cli and a library?
Linking this issue for reference