search

ajency / Impruw

The one ring that rules them all.
Other
0 stars 0 forks source link

Billing | Card | Display duplicate card error message even for new cards #950

Closed seonad closed 9 years ago

seonad commented 9 years ago

image

nutank commented 9 years ago

We can prevent duplicate credit cards from being added by enabling the "failOnDuplicatePaymentMethod" https://developers.braintreepayments.com/javascript+php/sdk/server/payment-method-management/create#preventing-duplicate-payment-methods . This means a credit card that is already added to the braintree vault cannot be added again which is the case currently and hence the error since that card is already added in the braintree vault before.

@anujkhurana is this behaviour ok? This would also mean there cannot be 2 sites having the same credit card associated to it.

anujkhurana commented 9 years ago

We don't the additional protection offered by fail on duplicate card. Please disable the check on braintree

On Wed, Jan 14, 2015 at 11:22 AM, nutank notifications@github.com wrote:

We can prevent duplicate credit cards from being added by enabling the "failOnDuplicatePaymentMethod"

https://developers.braintreepayments.com/javascript+php/sdk/server/payment-method-management/create#preventing-duplicate-payment-methods . This means a credit card that is already added to the braintree vault cannot be added again which is the case currently and hence the error since that card is already added in the braintree vault before.

@anujkhurana https://github.com/anujkhurana is this behaviour ok? This would also mean there cannot be 2 sites having the same credit card associated to it.

— Reply to this email directly or view it on GitHub https://github.com/ajency/Impruw/issues/950#issuecomment-69872448.

anujkhurana commented 9 years ago

We don't *need the

On Wed, Jan 14, 2015 at 12:10 PM, Anuj Khurana anuj@ajency.in wrote:

We don't the additional protection offered by fail on duplicate card. Please disable the check on braintree

On Wed, Jan 14, 2015 at 11:22 AM, nutank notifications@github.com wrote:

We can prevent duplicate credit cards from being added by enabling the "failOnDuplicatePaymentMethod"

https://developers.braintreepayments.com/javascript+php/sdk/server/payment-method-management/create#preventing-duplicate-payment-methods . This means a credit card that is already added to the braintree vault cannot be added again which is the case currently and hence the error since that card is already added in the braintree vault before.

@anujkhurana https://github.com/anujkhurana is this behaviour ok? This would also mean there cannot be 2 sites having the same credit card associated to it.

— Reply to this email directly or view it on GitHub https://github.com/ajency/Impruw/issues/950#issuecomment-69872448.

nutank commented 9 years ago

@anujkhurana But if that is disabled, a single site can have duplicate cards added. Would that be ok?

anujkhurana commented 9 years ago

you mean the same card being added to the same site multiple times? Not the ideal scenario but we can live with it. Would prefer this bug rather than blocking duplicate cards across all sites.

On Wed, Jan 14, 2015 at 12:13 PM, nutank notifications@github.com wrote:

@anujkhurana https://github.com/anujkhurana But if that is disabled, a single site can have duplicate cards added. Would that be ok?

— Reply to this email directly or view it on GitHub https://github.com/ajency/Impruw/issues/950#issuecomment-69875688.

nutank commented 9 years ago

ok :+1: