search

ajency / cashflow-issue-tracker

Issue Tracker for issues
0 stars 1 forks source link

BUG - If sync API fails, all values get updated as zero. #700

Closed nutank closed 4 years ago

nutank commented 4 years ago

Expected behaviour - If API fails at least older values should be retained for pnl_cogs, pnl_sales etc.

robiulpro commented 4 years ago

Fixed.

robiulpro commented 4 years ago

Going forward if api fails, the value should not get updated to zero in company cash table. Currently if api fails during syncing, the code blindly update the value to zero, this leads to override existing value with zero.

HazelColaco19 commented 4 years ago

Tested this by changing re-sync date to 2018 Jan.

Then random checks for pnl_cogs, pnl_sales values which were zero and compared to the report in QB for respective company. The values were zero in QB upon random check.

Closing ticket