search

ajenhl / tacl

Tool for performing basic text analysis on the CBETA corpus
GNU General Public License v3.0
30 stars 9 forks source link

Clarify behaviour of tacl report --extend on diff results #16

Closed ajenhl closed 9 years ago

ajenhl commented 10 years ago

The behaviour of tacl report --extend on a results file generated from a diff query (ie, that has no n-grams in common between two labelled sets of texts) is not specified. The actual behaviour is for the provided diff results to be returned, but this is not specified in the documentation. Furthermore, the process is carried out without any checking that no work actually needs to be done, so it is potentially a very slow way of getting the input as output.

It is possible that there is a use for a extension functionality on diff results. This would work in a very different way from that of the intersection extension (though the same command would suit), but such is not desired at this time.

ajenhl commented 10 years ago

aabde2f provides the documentation specifying that this is useless when applied to the results of a diff query.

ajenhl commented 9 years ago

The main part of this issue is fixed. The fact that it can be slow to run extend pointlessly on diff results is secondary and unlikely to be a concern. If it becomes so, a separate issue can be opened then.