ajenhl / tacl

Tool for performing basic text analysis on the CBETA corpus
GNU General Public License v3.0
30 stars 9 forks source link

Corpus.get_text(s) should be Corpus.get_witness(es) #50

Closed ajenhl closed 8 years ago

ajenhl commented 8 years ago

The Corpus methods get_text and get_texts should be renamed get_witness and get_witnesses, since a corpus deals with witnesses and not texts. Similarly, the Text class should be renamed WitnessText, and BaseText can be renamed Text. There's probably no point trying to escape the confusion there between "text" as textual content and "text" as a specific named work; if there were, rename the latter as "work" - this would only really matter for the results field name and the documentation and comments.