ajensen1234 / JTML

BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Clean up "wishy-washy" syntax and repeated/redundant function calls and logic #40

Closed nicholasverdugo closed 10 months ago

nicholasverdugo commented 1 year ago

Probably going to be a perpetual issue, but I'm creating this to help track changes. Branch will be called cleanup-main.

nicholasverdugo commented 1 year ago

Merged this branch with changes in main, so as of 1/27 cleanup is up-to-date.

nicholasverdugo commented 1 year ago

Commit 8481e19c615f9cbec8bdd2c5976be139671bc1f9 on 1-27. Started with removing comments, replacing if-else with ternary, and reducing repeated math with pre-calculated variables. No stability changes, everything seems to work as it did before.

ajensen1234 commented 10 months ago

Probably not going to get to all of this. I'm also not totally sure if Daniel plans on finishing this...

Anyway - we seem to be cleaning things up in other places as we go along. No need to a whole issue.