search

ajhowe / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

SUMMARY #5

Open sangjunp4rk opened 7 years ago

sangjunp4rk commented 7 years ago

Summary Grade: Satisfactory

Good job with your code! I really like the use of indentation! Also, good decisions on the classes and ids name. It makes it very clear what its purpose is and makes grouping your sections very effective. These organizational skills come in handy as you expand your code. Finally, good decision to save images locally! Saving images adds to the stability of your website because your website is not reliant on the link to be valid all the time. Great start to the Ready program!

I included a few notes in both the html file for you to think more critically about. First, make sure to add whitespace to organize your html code. Right now everything seems very compact and dense so it's difficult to parse through the lines. If you add extra lines in between sections it can help with readability. Finally, your lines are a bit long right now. Try splitting this into new lines so it's easier to read on one screen without scrolling. Convention is usually ~79 characters per line.

ajhowe commented 7 years ago

Thanks, I will take on board your advice re whitespace and line length. Cheers