search

ajhyndman / fire-emblem-working-title

A fledgling project wrangling Fire Emblem: Heroes stats
25 stars 6 forks source link

"Range" renamed to "WeaponRange" in FEH Wiki Weapons table #122

Closed minicircle closed 6 years ago

minicircle commented 6 years ago

Thank you @ajhyndman for this very useful package (fire-emblem-heroes-stats)! I've been using it to generate the data source for a TypeScript Discord bot that I wrote so that my small friend group can check IVs and skill effects quickly with up-to-date information.

When scraping stats today with the scrape-stats script, I noticed that all weapons were showing up as unknown skills for heroes. Looking at https://feheroes.gamepedia.com/Special:CargoTables/Weapons, it appears the "Range" column was renamed to "WeaponRange". This pull request should resolve the issue with scraping weapon information.

This also includes a possible fix for dual rally skills (e.g. Rally Spd/Def) showing up as unknown skills ("Warning: Oscar has unknown skill: Rally Spd/Def").

ajhyndman commented 6 years ago

Awesome! Thanks so much for contributing back, and I'm glad you're finding the package useful!